search

javalin / website

Javalin website source code
https://javalin.io
36 stars 87 forks source link

Issue with HTTP2 shading #218

Open Goksi opened 1 year ago

Goksi commented 1 year ago

Describe the bug While shading javalin ssl inside of spigot plugin, hpack http2 class is not included inside of ServiceLoaders, resulting ERR_CONNECTION_CLOSED Fixed by adding org.apache.maven.plugins.shade.resource.ServicesResourceTransformer transformer. Docs should be updated accordingly.

Screenshots image

zugazagoitia commented 1 year ago

@tipsy assign me and I'll work on it over the weekend (can't assign myself)

zugazagoitia commented 1 year ago

The docker tutorial #177 should also be reviewed.

javalin/javalin#1840 is relevant here.

tipsy commented 1 year ago

Done, thanks !

tipsy commented 10 months ago

Pretty long weekend @zugazagoitia !