search

javalin / website

Javalin website source code
https://javalin.io
36 stars 87 forks source link

Update migration-guide-5-6.md - AccessManager, skipRemainingHandlers #255

Closed elwin013 closed 6 months ago

elwin013 commented 6 months ago

Add information about ctx.skipRemainingHandlers() in beforeMatched

github-actions[bot] commented 6 months ago

🗑 Deploy Preview for javalin.io deleted.

Name Link
🔨 Latest commit e64af55e3c42bde68dee97ce3b32d8b821fdbfd4
🔍 Latest deploy log https://github.com/javalin/javalin.github.io/actions/runs/7409863377
elwin013 commented 6 months ago

Hi @tipsy,

I have migrated the Javalin5 AccessManager where I have context.redirect("/login") as a last step. Unfortunately without skipRemainingHandlers it is not working as expected - handlers is called and redirect is not performed. Not sure if it is correct or not so I'm proposing adding the note to migration guide :-)

tipsy commented 6 months ago

Thank you!