javalin / website

Javalin website source code
https://javalin.io
36 stars 87 forks source link

Outdated Micrometer plugin documentation #271

Closed varsanyid closed 2 months ago

varsanyid commented 3 months ago

Hi,

The getting started docs about the Micrometer plugin indicate that the plugin can be instantiated like this:

MicrometerPlugin micrometerPlugin = MicrometerPlugin.Companion.create(micrometerConfig -> micrometerConfig.registry = registry);

However, the Companion object has no create method as per the latest version of the plugin and can only be created the following way: MicrometerPlugin { it.registry = registry }

tipsy commented 3 months ago

Thanks for reporting @varsanyid, would you like to submit a PR to fix this?

varsanyid commented 2 months ago

@tipsy sorry about the slow response raised a PR #274 to update the samples

tipsy commented 2 months ago

Thank you very much :)

tipsy commented 2 months ago

Merged !