search

javamachr / sonar-gitlab-plugin

Add to each commit GitLab in a global commentary on the new anomalies added by this commit and add comment lines of modified files
GNU Lesser General Public License v3.0
121 stars 21 forks source link

Rename codeclimate.json to gl-code-quality-report.json #2

Closed 123Haynes closed 3 years ago

123Haynes commented 3 years ago

Gitlab renamed this file in 11.0 and uses the new name in all code quality jobs.
We should do the same to avoid confusion when reading the different docs.

Warning: BREAKING CHANGE

This will require people to update their existing jobs to the new name.

lucasoares commented 3 years ago

This PR has lots of changes in code style. I suggest you to only change the necessary code.

In parallel, maybe we should add a lint to force the style?

Google java format for me is a good one: https://github.com/google/google-java-format

If its a good thing to do I offer myself to create the issue and the PR.

123Haynes commented 3 years ago

@lucasoares ah my bad. I had prettier configured for new projects in my ide. I'll fix the PR.

123Haynes commented 3 years ago

@lucasoares Now it should be good to go. Sorry about the mishap with the code formatting.