javamanatee / frederick-rolfe_hadrian-the-seventh

Epub source for the Standard Ebooks edition of Hadrian the Seventh, by Frederick Rolfe
Other
0 stars 0 forks source link

Issues: #1

Closed EmmaSweeney closed 10 months ago

EmmaSweeney commented 10 months ago

General Issues:

preface.xhtml:

prologue.xhtml:

chapter-3.xhtml:

chapter-4.xhtml:

chapter-6.xhtml:

chapter-11.xhtml:

chapter-14.xhtml:

chapter-16.xhtml:

chapter-24.xhtml:

local.css:

footer{ margin-top: 1em; text-align: right; }

[epub|type~="z3998:salutation"] + p, [epub|type~="z3998:letter"] header + p{ margin-top: 1em; text-indent: 0; }

[epub|type~="z3998:sender"], [epub|type~="z3998:salutation"], [epub|type~="z3998:signature"]{ font-variant: small-caps; }

[epub|type~="z3998:postscript"]{ margin-top: 1em; text-align: initial; text-indent: 0; } / End letters /


- [x] The header CSS for the Prooimion can be simplified.

/ Subchapter headers / [epub|type~="prologue"] header{ font-variant: small-caps; margin: 1em; text-align: center; } / End subchapter headers /


- [x] For styling the spacing in "Signs of Smouldering Revolt", use the following CSS so that it doesn't conflict with the header CSS.

/ Special datelines /

prologue-3 p + p{

margin-top: 1em;

} / End special datelines /



- [x] Copy and paste the dedication CSS from the manual ([SEMOS 7.3.1](https://standardebooks.org/manual/1.7.3/single-page#7.3.1))
javamanatee commented 10 months ago

I think I got everything, so back over to you.

EmmaSweeney commented 10 months ago

A few more issues:

prologue.xhtml:

chapter-4.xhtml:

chapter-11.xhtml:

chapter-18.xhtml:

javamanatee commented 10 months ago

Back to you. Now that I see I'm missing language tags on lots of pubs, here is a list of remaining candidates. Let me know what you think.

src/epub/text/chapter-3.xhtml:name.publication.book">Satyricon -- Latin? Or leave as is? A Latin work that looks Greek. src/epub/text/chapter-7.xhtml:name.publication.newspaper">Il Popolo Romano -- Italian src/epub/text/chapter-13.xhtml:name.publication.newspaper">Vorwaerts -- German src/epub/text/chapter-13.xhtml:name.publication.newspaper">Éclair -- French src/epub/text/chapter-13.xhtml:name.publication.newspaper">La Patrie -- French src/epub/text/chapter-17.xhtml:name.publication.newspaper">Populo Romano -- Italian src/epub/text/chapter-11.xhtml:name.publication.book">Epinikia -- Greek? src/epub/text/prologue.xhtml:name.publication.newspaper">Pridjeprowski Krai -- Not sure? This word only appears in this book. src/epub/text/prologue.xhtml:name.publication.book">Encheiridion -- Greek? An anglicized form is in M-W.

EmmaSweeney commented 10 months ago

src/epub/text/chapter-3.xhtml:name.publication.book">Satyricon -- Latin? Or leave as is? A Latin work that looks Greek.

leave as is.

src/epub/text/chapter-7.xhtml:name.publication.newspaper">Il` Popolo Romano -- Italian

Add a language tag.

src/epub/text/chapter-13.xhtml:name.publication.newspaper">Vorwaerts -- German

Add a language tag.

src/epub/text/chapter-13.xhtml:name.publication.newspaper">Éclair -- French

Leave as is.

src/epub/text/chapter-13.xhtml:name.publication.newspaper">La Patrie -- French

Add a language tag.

src/epub/text/chapter-17.xhtml:name.publication.newspaper">Populo Romano -- Italian

Add a language tag.

src/epub/text/chapter-11.xhtml:name.publication.book">Epinikia -- Greek?

Leave as is.

src/epub/text/prologue.xhtml:name.publication.newspaper">Pridjeprowski Krai -- Not sure? This word only appears in this book.

I don't know what language that is, so leave as is.

src/epub/text/prologue.xhtml:name.publication.book">Encheiridion -- Greek? An anglicized form is in M-W.

Leave as is.

javamanatee commented 10 months ago

Ready for review.

javamanatee commented 10 months ago

Also forgot the collection metadata! That is in there now.