Open vr8hub opened 1 month ago
Alex replied the tables could be rearranged to make them clearer/more compact, so here are my thoughts about the tables.
Deaths 1880 Deaths 1889 Death rate 1880 Death rate 1889
or
Deaths Death Rate
1880 1889 1880 1889
For the population table(s) that contain London, since it is 1881 rather than 1880 like the rest, either make a note on London that it's 1881, or, rather than making 1880 and 1889 the column headers, there could be two separate columns for "Year", with 1880 or 1881 in the first, and 1889 in the second.
Will keep in mind to break down commits for the future. I was trying to follow the step-by-step guide closely, which is supposed to make things easier. It strongly implies that one should find all the semantics and... "After you’ve added semantics according to the SEMoS, do another commit..." Maybe that could be stated better in the guide.
Very good question about the picture after introduction. PG transcription has <hr class="chap"/>
after the image and before chapter 1. The places in the caption are not referenced until much later chapters (actually Sebastopol is never mentioned again!)
The woodcuts are supposed to be "two color" so all the dark grays have to become black. I tried to get the right balance with the threshold points to not lose a lot of detail but also not overly obscure things. Some of these have very fine detail and we're at the mercy of the jpeg compression muddying things up a little.
We discussed the decorative illustrations way at the beginning. I think Alex said keep them, but maybe you could look back at what we said and see if I misinterpreted Alex's response. My full page pics tend to be 2000 x something (I even had to scale them down just a little, to meet SEMOS requirements for max dimensions.) The barrel is 752 x 777. I think images expand to full width by default. I can put some CSS max-height on the smaller ones. I thought the SVGs would also expand, but they're obeying the viewBox size... I'll try and fix those.
I saw the "To-day" text in the SVG and wasn't sure if we edit "pictures" of text! I should be able to modernize that, and I'll work through some of these other things and let you know when it's ready for another look.
And, I realize I didn't explicitly say—this is your production, so the above are just thoughts, not commands. :) Let me know if you have different thoughts.
Re the commits, the big yellow box at the beginning says keep one unit of work, so that's the overriding sentiment. I do get what you mean about the manual semantic commit and I'll talk to Alex about it; the problem is that not all of those things are needed on every production, so the step-by-step can't really say make one commit or four commits: it depends on how many things are changing. Which is where "one unit of work" comes back in.
Yeah, I was just curious if it was obvious which one it went with. If you're comfortable it's with the introduction, I'm great with that, no change needed.
Right, I understand the challenges, and I'm not a good arbiter of SVG's or any other illustration. I wouldn't have said convert them to SVG in the first place, but I often get such things wrong. :) I'll leave it with Alex, and if he's good, that's all that matters.
Alex said cut the decorative ones; 4 on your list was decorative.
Yes to all of these except 4, you can keep all the illustrations as this is nonfiction.
As I said, I'm not sure, either, but I would certainly expect so—it obviously doesn't materially change the picture, and in different circumstances, I would say leave out the text out of the picture entirely and put it in the figcaption. The fact that the text is specific to each picture makes that more difficult, so this is a compromise.
I had "1 - keep, 2 - keep, 3 - keep, 4 - cut?", so I took "Yes to all except 4" to be "no cut", especially as he followed it with "keep all illustrations." :) These were categories, not illustration numbers, with "4" meaning all decorative ones. But I'll go with what you say. I probably overthunk it. In that case, illustration-10 and illustration-20 are also decorative and should also be cut? In which case I will renumber the remaining ones as needed.
On Wed, Jul 17, 2024 at 11:49 PM vr8hub @.***> wrote:
Re the commits, the big yellow box at the beginning says keep one unit of work, so that's the overriding sentiment. I do get what you mean about the manual semantic commit and I'll talk to Alex about it; the problem is that not all of those things are needed on every production, so the step-by-step can't really say make one commit or four commits: it depends on how many things are changing. Which is where "one unit of work" comes back in.
Yeah, I was just curious if it was obvious which one it went with. If you're comfortable it's with the introduction, I'm great with that, no change needed.
Right, I understand the challenges, and I'm not a good arbiter of SVG's or any other illustration. I wouldn't have said convert them to SVG in the first place, but I often get such things wrong. :) I'll leave it with Alex, and if he's good, that's all that matters.
Alex said cut the decorative ones; 4 on your list was decorative.
Yes to all of these except 4, you can keep all the illustrations as this is nonfiction.
As I said, I'm not sure, either, but I would certainly expect so—it obviously doesn't materially change the picture, and in different circumstances, I would say leave out the text out of the picture entirely and put it in the figcaption. The fact that the text is specific to each picture makes that more difficult, so this is a compromise.
— Reply to this email directly, view it on GitHub https://github.com/javamanatee/jacob-riis_how-the-other-half-lives/issues/1#issuecomment-2235325619, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOZVYAMQTSWA2H2T32RF27LZM5CNLAVCNFSM6AAAAABK72CNA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZVGMZDKNRRHE . You are receiving this because you commented.Message ID: <javamanatee/jacob-riis_how-the-other-half-lives/issues/1/2235325619@ github.com>
He was saying yes to all illustrations but 4. He said "keep all illustrations" because normally we cut 1, 2, and 3, too. Cutting decorative illustrations is across the board, keeping other illustrations only happens for non-fiction (except for the rare "referred to in the book" ones in fiction).
If they're decorative, then they go. Yes to renumbering the remainder. There is a shift-illustration command that might help; unfortunately we don't have a renumber-illustrations like we do renumber-endnotes.
All right, I've been a little sidetracked with real life stuff, but I think it's finally ready for another look. I think I got all the issues discussed. I'll appreciate further critiques or recommendations on the table formatting.
You and me both. The tables overall look great, thank you for those changes! A few formatting nits:
br
so that the "census" was forced under the rest of the text where it occurs, but I don't believe that would fly with Alex, so we'll leave them as is.Illustration 3/5 are now as big (almost full page) as they were small before, but I'm going to leave them and let Alex make/request more changes if he prefers. :)
I put a vertical alignment:bottom for table cells and left-align by the dittos. Nits have been picked!
[ ] No change needed this time, but the initial "Manual semanticate" commit has at least four different things going on in it: fiction to non-fiction, the titles, the italics, and the name abbreviations. I would suggest for future projects those be four different commits; reviewing a single commit with those quantities of diverse changes in it is difficult.
[x] For mismatched dashes, saloonkeeper is in M-W, albeit in unabridged, so that's we would go with.
[ ] Forgive what is probably an obvious question, but does the text make clear that the picture between the introduction and chapter 1 goes with the introduction rather than chapter 1?
[x] Illustration 3 displays like this, at least in Apple's Books app.![image](https://github.com/user-attachments/assets/7c22cdbe-5c75-43ef-9588-89cd909ff486)
[x] Illustration 5 has the same problem, but not as severe.
[ ] The SVG's are also much darker than the originals, to the point it's hard to tell what the pictures are of. I don't know what's to be done about it (I struggle with SVG's myself), but I'll note it with Alex.
[x] Conversely, the barrel end-of-chapter illustration in chapter 1 displays huge compared to the scans (takes up most of a page).
[x] Speaking of which, those end-of-chapter pictures that aren't in the LOI appear to me to be decorative, and therefore excisable. Is there a reason they were kept?
[x] Table columns that consists of all numbers should be right-justified; see the example in SEMoS 8.19.1.
[x] In the chapter 13 table, I think we want the padding you have on the numeric columns to be on the headers for those columns, as well as the first column on the right-hand side. IOW, just like you moved the right-most column of the left-hand side away from the line, we want to do the same to the left-most column of the right-hand side. And the headers of both columns should get the same padding.
[x] I could be wrong, but I think Alex might expect the SVG in chapter 24 to be edited to change "To-day" to "Today," i.e. remove the dash and move the "day" to the left.
I'm sure you saw the couple of questions I asked Alex about this on list. Depending on his answers, there may be nothing more to do, or there might something. :)