search

javamelody / grails-melody-plugin

JavaMelody monitoring plugin for Grails, to monitor application performance
https://plugins.grails.org/plugin/grails-melody-plugin
Apache License 2.0
32 stars 31 forks source link

grails-melody-plugin issue 43 #50

Closed jukin-jerry closed 6 years ago

jukin-jerry commented 7 years ago

Apply fix proposed by graemerocher in grails-core-10715: not a grails-core bug but instead in the plugin; https://github.com/grails/grails-core/issues/10715#issuecomment-317304931

evernat commented 7 years ago

This pull request si too short. Have you tested it? Are services still monitored? Why was this call needed before Grails 3 and why it is not needed anymore? Why writing grailsVersion=3.2.11 in gradle.properties fixes the issue without this PR? See also https://github.com/grails/grails-core/issues/10715#issuecomment-315648780

bassmartin commented 6 years ago

Applying this fix makes one of my test work (that was not working without the change) that modifies the metaclass of a domain class and uses @ConfineMetaClassChanges annotation.

I'll create a project that reproduces this.

I will now check that the plugin still monitor service with that change.

bassmartin commented 6 years ago

I still get stats about services in my project.

sergiomichels commented 6 years ago

@evernat I've checked that we have this ExpandoMetaClass.enableGlobally() since the SVN version of the plugin, so it's probably linked with an old version of Groovy... Since Martin tested it I think we can merge it.

bassmartin commented 6 years ago

We can safely remove the call as it's for older Groovy versions (see response of Burt) : https://stackoverflow.com/questions/34447528/what-are-the-costs-of-using-expandometaclass-enableglobally-groovy

evernat commented 6 years ago

Since the services are still monitored and give stats, it's ok to me.