javamelody / jira-confluence-javamelody

JavaMelody plugin for JIRA, Confluence or Bamboo
Apache License 2.0
13 stars 6 forks source link

Duplicate Monitoring menu entries in Confluence 8.5 but none pointing to javamelody #32

Closed dukethepenguin closed 9 months ago

dukethepenguin commented 1 year ago

I just installed Javamelody 1.95.0 in Confluence 8.5 and got two "Monitoring" menu entries, as Confluence now has added its own Monitoring menu entry.

But having two menu entries named Monitoring is not the problem. The problem is that Confluence links both of them to their own newly added page /admin/viewmonitoring.action instead of one to their own /admin/viewmonitoring.action and the other to javamelodys /monitoring.

Entering /monitoring manually in the browser still gets you to javamelody though.

evernat commented 1 year ago

Strange that Confluence steals the javamelody menu item defined, at the end of the atlassian-plugin.xml file inside the plugin jar, by the following :

    <web-item key="net.bull.javamelody.confluence-web-item"
        name="Monitoring" section="system.admin/administration"
        i18n-name-key="net.bull.javamelody.web-item" weight="10">
        <icon height="16" width="16">
            <link>/monitoring?resource=systemmonitor.png</link>
        </icon>
        <label key="net.bull.javamelody.label">Monitoring</label>
        <link linkId="net.bull.javamelody.link">/monitoring</link>
    </web-item>

Ref https://developer.atlassian.com/server/confluence/web-ui-modules/

evernat commented 1 year ago

If you test and find which atlassian-plugin.xml fix the issue, I send you a French crêpe. I make it myself and it smells good with a bit of dark rum from Martinique inside.

evertol commented 11 months ago

To resolve this issue, assign a unique name to the menu item. Modify javamelody_i18n.properties by replacing net.bull.javamelody.label=Monitoring with a distinct name, such as net.bull.javamelody.label=Monitoring (javamelody).

evernat commented 9 months ago

@evertol Strange that a label of a link changes the link itself. But thanks.

I owe you a French crêpe with (dark) rum from Martinique, so here is one version: https://www.casseroleetchocolat.fr/en/les-crepes-de-la-chandeleur/ (in English). There are many other versions.