search

javamelody / liferay-javamelody

JavaMelody plugin for Liferay
Apache License 2.0
6 stars 8 forks source link

Add support to Liferay Portal version 7.0 #7

Closed inacionery closed 7 years ago

inacionery commented 7 years ago

Hi

this pull only will works with this other https://github.com/javamelody/javamelody/pull/611.

Thanks!

evernat commented 7 years ago

Thanks for notifying us about Liferay changes and also for submitting pull request. That's much appreciated.

But I think that it is a bad idea from Liferay to cut libraries apis in pieces (some api parts are no longer available), that's not respectful of api designers. And I think it is a bad idea from Liferay to rename Liferay packages without any backward compatibility, that's not respectful of developers.

As said in reviews, the PR needs some changes to be merged. Thanks again.

evernat commented 7 years ago

I will merge and restore Liferay 6.1+ compatibility after that. Thanks for the pull request.

evernat commented 7 years ago

Released as 1.63.1 of liferay-javamelody: https://github.com/javamelody/liferay-javamelody/releases/tag/1.63.1