search

javamonkey79 / velocity-maven-plugin

Automatically exported from code.google.com/p/velocity-maven-plugin
0 stars 0 forks source link

UTF-8 characters in templates destroyed #2

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Have template with national, non-ANSI (UTF-8) character
2. Process the template
3. The national character gets scrambled

What is the expected output? What do you see instead?
National characters in UTF-8 should remain untouched.

What version of the product are you using? On what operating system?
1.0.0

Please provide any additional information below.
The plugin uses org.apache.velocity.app.Velocity.getTemplate(String name), 
which reads the template in ISO-8859-1. This destroys any UTF-8 characters in 
the template. Saving the processed result subsequently in UTF-8 is correct but 
not sufficient. The plugin must use the 
org.apache.velocity.app.Velocity.getTemplate(String name, String  encoding) 
method instead.

Original issue reported on code.google.com by ivo.maix...@gmail.com on 6 Jul 2012 at 8:04

GoogleCodeExporter commented 9 years ago 
Attaching the patch.

PLEASE, apply the patch(es) and release to maven central. Thank you!

Original comment by ivo.maix...@gmail.com on 19 Jul 2012 at 7:25

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by javamonk...@gmail.com on 26 Dec 2013 at 10:25

GoogleCodeExporter commented 9 years ago 
The changes have been released to v1.1.0.

Original comment by javamonk...@gmail.com on 27 Dec 2013 at 5:00

GoogleCodeExporter commented 9 years ago 
Confirming fixed.
Thanks, Ivo.

Original comment by ivo.maix...@gmail.com on 30 Dec 2013 at 10:49