search

javaneil / Carson

Carson the Coffee Butler
0 stars 0 forks source link

Code review 2 #5

Open vangkyle opened 7 years ago

vangkyle commented 7 years ago

Design/Code Review 2

Project: Carson the Coffee Butler

Developer: Neil Fortney

Reviewer: Kyle Vang

Category Criteria Analysis/Comments
Running application
Describe the application functionality that has been built and is working.
What is good?
What could be improved?
Unit Tests
What are the code coverage statistics?
Are @Before/@BeforeClass/@After/@AfterClass used to reduce redundant code? yes, @Before
JSPs
Is templating used to eliminate rundandant code(for example, header.jsp, footer.jsp, etc.) yes
What is good?
What could be improved?
Code quality
Are methods single-purpose? yes
Are classes appropriately-sized classes (no monster classes)? yes
Are the same lines of code repeated at all? no
Do any classes perform very similar functions that could be candidates for super/subclass relationships?
Are any values hard-coded that should be in a properties file? No
Are variable names descriptive? yes
Are there many branches or loops that could be simplified or broken up into smaller methods? no
Do the DAOs use Hibernate? No hard-coded sql! yes
Has log4J been added? yes
Are there logging statements in the code? yes
Are appropriate logging levels used? Info, debug, error, for example. yes
Are there any System.out.printlns in the code? no
Other comments/notes? Great use of comments.
Web Service/API integration Which web service/api is being used? TBD
Is the integration built?
If so, evaluate the integration code. What is good? What could use improvement?
Independent research topic What is the developer's independent research topic? TBD
Has the topic been implemented in the project?
If so, evaluate the implementation. What is good? What could use improvement?
Key takeaways List at least 3 things you learned while reviewing this project that will help you in your own project.
pawaitemadisoncollege commented 7 years ago

This review appears incomplete - can you add in the functionality that is currently implemented? Log in, add account, search? Compare what works to what is listed in the application problem statement. I'm looking for a bit more critical thought here - what did you learn looking at this project? What is good, what could be improved?