search

javapathfinder / jpf-core

JPF is an extensible software analysis framework for Java bytecode. jpf-core is the basis for all JPF projects; you always need to install it. It contains the basic VM and model checking infrastructure, and can be used to check for concurrency defects like deadlocks, and unhandled exceptions like NullPointerExceptions and AssertionErrors.
517 stars 326 forks source link

shoaib/issue#439 #465

Open sshaikshoaib opened 1 week ago

sshaikshoaib commented 1 week ago

i have changed .equals function to .compareTo function. hope it works

cyrille-artho commented 1 week ago

Thank you for your implementation. Please also provide a unit test so we know that the new version of the code works as intended. See the wiki for instructions on how to write unit tests: https://github.com/javapathfinder/jpf-core/wiki/Writing-JPF-tests

sshaikshoaib commented 1 week ago

Hi @cyrille-artho I am a beginner and I have a good knowledge on java.so i used this knowledge to rectify the issue. so give me some time as Iam a beginner I don't know how to write test cases. But i have an Immense interest in contributing to java projects.so can you just me how to write test cases

sshaikshoaib commented 1 week ago

i have added the required tests for the updated code. please revies that and suggest me if any updates required

cyrille-artho commented 1 week ago

Hi, Thank you for the test. It fails, which means the test shows the problem with the typecast not happening as expected, but the code change in the main code does not fix the bug yet.

cyrille-artho commented 1 week ago

Thanks! This patch seems to fix the problem. To merge it, can you please remove the extra file .vscode/settings.json? You accidentally added it, and you can simply use git rm -f .vscode/settings.json followed by a commit on your branch (shoaib/issue#439) to remove it. Once you push that change, this pull request will be updated automatically.