Update to 0.10.0 release

javascript-obfuscator / javascript-obfuscator-ui

A web UI to the JavaScript Obfuscator node.js package.

https://obfuscator.io

BSD 2-Clause "Simplified" License

230 stars 130 forks source link

Update to 0.10.0 release #7

Closed sanex3339 closed 7 years ago

sanex3339 commented 7 years ago

https://github.com/javascript-obfuscator/javascript-obfuscator/blob/master/CHANGELOG.md#v0100

Hi. Please update web ui to next 0.10.0 version.

Bunch of new options were added and default value for two old options was changed.

slig commented 7 years ago

Will try to do this today.

slig commented 7 years ago

Updated. Please see if you agree with the small re-organisation of the options and the texts.

sanex3339 commented 7 years ago

Thank you! Everything is ok. But can you move mangle names option under compact option and wrap them into group?

slig commented 7 years ago

You mean something like that?

Also, should I rename the option from "Mangle Variable Names" to "Mangle Names"?

sanex3339 commented 7 years ago

Yes, but with line under selfDefending

slig commented 7 years ago

Done. Uploading now.

sanex3339 commented 7 years ago

Thank you!

slig commented 7 years ago

Hi,

The new 0.10 branch introduced this breaking change:

Breaking change: escapeUnicodeSequence option now disabled by default.

I'm not sure why I didn't put this option explicitly on the UI before, so it was using the default enabled value so far, which now is disabled.

I just received an email from a user reporting this change and decided to bring it here:

Should we have an extra option for this on the UI, right? Keeping it enabled as it was before feels strange because it's disabled by default on the library, and having it off without an option doesn't look good too.

sanex3339 commented 7 years ago

Right way - add checkbox with this option and disable it by default.