javascript-studio / studio-changes

📦 Generate a changelog as part of the npm version command
https://medium.com/javascript-studio/nice-and-easy-module-releases-a32c906b564e
MIT License
49 stars 7 forks source link

Header detection depends on LF #1

Closed tivac closed 7 years ago

tivac commented 7 years ago

https://github.com/javascript-studio/studio-changes/blob/b32a534b58ee8b271d043962ee7f2c78852a8501/lib/changes.js#L12

Means that if you're on windows and the file is automatically checked out with CRLF changes will fail with a Unexpected CHANGES.md file header message.

Hopefully a small fix, for now I've forced the file to use LF but that isn't ideal IMO.

mantoni commented 7 years ago

Oh, yes. Good catch. Also potentially here. Will look into it.