Closed tivac closed 6 years ago
Thank you!
I guess the git command would fail if a property cannot be read from the package. Did you check what happens?
Otherwise, this looks good to me. I can merge and cut a release for you this evening 👍
I don't currently handle that case right now. What would be your preference for how to handle that scenario?
My instinct would be to have buildTag()
throw an error and wrap changes.write()
in cmd.js
within a try/catch
. Sound reasonable?
Yeah, I don’t know. Was just a thought. We can add error handling later if it actually causes issues ... let’s keep it simple 🙂
Can I ask you to add the documentation for —tag
in the readme as well?
@mantoni Oof, embarassing. Updated readme.
Thanks a lot! Released as v1.4.0
🎉. See release notes.
I also made a few internal changes to avoid having the file name and the tag format as global state :)
Removal of global state is a good change, I was trying not to rearrange too much furniture in a repo I don't own 😅 Sorry about the lint bugs, it was passing for me when running locally!
No worries. All good. I also prefer pull requests that deal with one thing at a time 👍
Supports the parsed version from
CHANGES.md
as${version}
along w/ any other string-compatible key inpackage.json
.Now it's possible to use this lib with lerna!
Fixes #15