javascript-studio / studio-changes

📦 Generate a changelog as part of the npm version command
https://medium.com/javascript-studio/nice-and-easy-module-releases-a32c906b564e
MIT License
49 stars 7 forks source link

Add gitignore for node_modules folder #4

Closed crookedneighbor closed 7 years ago

mantoni commented 7 years ago

I have node_modules ignored in a global ignore file, since you never want it to be checked in. Would that be an option for you as well?

crookedneighbor commented 7 years ago

I only put the stuff that applies to my global system in my global gitignore (Vim swap files, Mac .DS_STORE files, etc).

I've worked on apps where node_modules are checked in (as weird as that is), so adding node_modules to my personal global gitignore isn't an option. Most node projects I've ever contributed to have the local gitignore file, but if y'all don't want to have that for this project, feel free to just close the PR.

mantoni commented 7 years ago

Naah, I always had a .gitignore with this one folder in my projects. This is the first time I tried without. Merging 👍