javascript-studio / studio-changes

📦 Generate a changelog as part of the npm version command
https://medium.com/javascript-studio/nice-and-easy-module-releases-a32c906b564e
MIT License
49 stars 7 forks source link

Does not wait for VS Code to return #7

Closed TekSiDoT closed 7 years ago

TekSiDoT commented 7 years ago

When using Visual Studio Code as the editor referenced in the EDITOR env variable, changes does not wait for VS Code to return.

Changes made to CHANGES.md are thus not committed.

mantoni commented 7 years ago

If the command line call to VSC returns immediately, there isn't much we can do. Maybe there is a switch to make the call blocking?

TekSiDoT commented 7 years ago

Makes sense, I'll check it out on the VSC side, thanks!

mantoni commented 7 years ago

I found it here: https://code.visualstudio.com/docs/editor/codebasics#_additional-command-line-arguments

The option you're looking for is -w or --wait. You can this flag to the $EDITOR variable to cause VSC to wait before returning.

TekSiDoT commented 7 years ago

Excellent, thank you!