Open iliakan opened 5 years ago
p.s. not sure if rtl.styl
is used now, I created it just to make sure things can work out.
Sidebar must be on the right I'm tried to specify the style for ar in body.styl and rtl.style but seems not to work in both
You'd like to have a working rtl.styl
? Anything else?
No thank you and thanks for your help š
No - means no rtl.styl
? Nothing needed? š®
No I just need only a working rtl.styl I need a style file and nothing else and thnx for help š
Ok, I'll do it and write here.
I pushed the change. Instead of a separate rtl.styl
file, you have the variable rtl
in styles now.
That's better, as RTL styles can be naturally embedded into stylesheets.
Like this:
body
color white
if rtl
direction rtl
Got it thanks I will make a necessary changes and then make a pull request
@iliakan
For sorry your latest changes didn't work with me
I updated it once again.
Try ./edit ar
- you should see green body:
@iliakan It's not working & i'm using this to serve ./edit ar
You do it, and then re-run ./edit ar?
Also, do you clear browser cache?
Best Regards, Ilya Kantor https://javascript.info
On 22 May 2020, at 00:43, Omar Hasan notifications@github.com wrote:
@iliakan https://github.com/iliakan It's not working https://user-images.githubusercontent.com/8146344/82609386-bf11e780-9bbc-11ea-979d-c7a86225dcd0.png https://user-images.githubusercontent.com/8146344/82609407-cafda980-9bbc-11ea-9a16-147275c804a7.png ā You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/javascript-tutorial/ar.javascript.info/issues/1#issuecomment-632361839, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACVJGEK3NQNEJPVL6EONH3RSWN67ANCNFSM4ILYTUNA.
Yes I'm closed and reserving about 5 times and I'm serving on incognito window
So my change isn't working for you?
Here's how it should look:
Please note: incognito doesn't mean "no cache". It merely hides your identifying tokens/empties the environment. So you may still have it cached. I guess, that's the reason.
Also, when you see things working, you can try ./dev ar
(as described in the readme, see Dev mode).
Please check public/en/pack/styles.css
, are the changes there, in the body{...}
clause?
I got this error when using ./dev ar
and there no rtl
in styles.css
Yes, ./dev
expects to see ar.yml
files, the translation of the web interface. That's not needed for ./edit
that uses en.yml
by default.
Note: rtl.styl is not used now. There should be body{...}
style with the change.
I'm using this file server\modules\styles\blocks\body\body.styl
and this is what it includes
i think it reads rtl as variable direction: false
Here is the problem
Strange, please git pull
latest?
Here's my edit
:
/js/server master> cat edit
#!/usr/bin/env bash
# ./edit ru <- tutorial language: RU, server: EN
# ./edit ru ru <- tutorial language: RU, server: RU
: ${1?"Usage: $0 <tutorial language> [<server language>]"}
export TUTORIAL_ROOT="../$1.javascript.info"
export NODE_LANG="${2:-en}"
export TUTORIAL_LANG=$1 <-------------------------
So when you run ./edit ar
, the variable should be there.
It's the latest already
That's odd indeed. Why the variable does not get through then?
I'm using the engine and server and ar projects through the fork, can this make any problems?
If you pull from upstream, so that the fork is up to date, then it shouldn't be the reason.
did you recommend to remove the local and fork projects and repeat this process again?
The edit
file is correct: there's the variable TUTORIAL_LANG
. But then it must be in process.env.TUTORIAL_LANG
. That has nothing to do with my scripts, it's a straightforward node.js feature.
I think i've found what we can fix and made a PR for it I'm using windows btw
Of course, that explains everything. I assumed you're running ./edit
, not ./edit.cmd
. Great, so now it works!
@iliakan I think there is a problem related to displaying SVG is that just a local issue for me?
Do you have ImageMagick installed? It tries to get image size.
It might be better to make separate issues for different stuff, not to write everything here, in the progress tracker. Here in the same repo.
ok no problem but did we need to install ImageMagick
No need, unless you want to see pictures locally.
I also made a PR for RTL in server hope changes merged to use it with my team
I'll merge it later, after you evaluate it during the translation, ok? Anyway, RTL isn't yet used, as no translation exists.
My Team about 18 developers is using this style and they have now yesterday version with background green
at least this PR
Yes, green was temporary =) merged it.
Symbol type
Manuals and specifications
An Introduction to JavaScript
Object to primitive conversion
Comparisons
Basic operators, maths
Iterables
Property getters and setters
Attributes and properties
Property flags and descriptors
Maintainer List
@alahnomi, @Jamil-Bailony, @3imed-jaberi, @atefBB, @afilahkle
For New Translators
Please read this first (click to open)
To translate an article: 1. Check that no one else has claimed your article in the checklist below. 2. Comment below with the title of the article that you would like to translate, exactly as listed, e.g. `An Introduction to JavaScript`. - Please take only one article at a time. 3. Fork this repo, translate the article in your fork and submit a pull request! - The pull request title should be same as the article, e.g. `An Introduction to JavaScript` (just like comment) Please be prompt with your translations! If you find that you can't commit any more, let maintainers know so they can assign the page to someone else.
For Maintainers
Click to open
We recommend that a translation has 2 reviews to be merged. Please let others know what you do, on community boards and chats, invite them to join. Translations become better if more people see them. Translations are tracked below, like this: * [ ] [Home Page](url) (@iliakan) #1 Our helpful bot watches comments and adds the translator nick and PR id, marks completed, when PR is merged. You can read the details at.
If something doesn't work right, please contact @iliakan.
Team translation
More details about team translation: https://javascript.info/translate/bot.
Only maintainers can check/uncheck items below. If you're not, please write in a comment what you take to translate, the title, exactly as in the list.
The JavaScript language
An introduction
JavaScript Fundamentals
Code quality
Objects: the basics
Data types
Advanced working with functions
Object properties configuration
Prototypes, inheritance
Classes
Error handling
Promises, async/await
Generators, advanced iteration
Modules
Miscellaneous
Browser: Document, Events, Interfaces
Document
Introduction to Events
UI Events
Forms, controls
Document and resource loading
Miscellaneous
Frames and windows
Binary data, files
Network requests
Storing data in the browser
Animation
Web components
Regular expressions