javascript-tutorial / en.javascript.info

Modern JavaScript Tutorial
https://javascript.info
Other
23.6k stars 3.88k forks source link

Publish Persian translations #3172

Closed mahdyar closed 2 years ago

mahdyar commented 2 years ago

Hi, It seems like we've made it at fa.javascript.info! 🥳

As mentioned in the "Publish" part of this page, it's now more than half-finished.

image

cc @iliakan

Beroozam commented 2 years ago

I am waiting too. Thanks everybody.💪❤

iliakan commented 2 years ago

Well done, I'll carry this forward tomorrow! 🎸

mahdyar commented 2 years ago

Well done, I'll carry this forward tomorrow! 🎸

Hi, any updates on this?

iliakan commented 2 years ago

Sorry, not yet, will be publishing very soon.

iliakan commented 2 years ago

Sorry for the delay, had really pressing matters to attend to. Now let's get publishing ;)

This is the archive with site interface phrases: locales.zip

Please translate all files: keep English to the left, and make them Farsi to the right, all quoted.

Keep the file structure "as is", then send back the translated archive.

mahdiHash commented 2 years ago

2022-09-10_230934

Hi, @iliakan.
I was wondering if we have to surround all the right phrases in quotation marks. What about the ones already including quotes (e.g. the repo address in the image)? Single quotes are supported, right?

iliakan commented 2 years ago

I'm not sure about Farsi, please use double quotes to make sure it's all good.

iliakan commented 2 years ago

and \" for quotes inside quotes =)

mahdyar commented 2 years ago

Hi, it's done: locales.zip

Let us know if something's wrong.

cc @iliakan @mahdiHash

mahdiHash commented 2 years ago

Hi, it's done: locales.zip

Let us know if something's wrong.

cc @iliakan @mahdiHash

No problem I see :)

iliakan commented 2 years ago

Please fix the duplicate (see the English version, should be only one of them):

mahdyar commented 2 years ago

Please fix the duplicate (see the English version, should be only one of them):

* ./1-js/07-object-properties/03-prototype-inheritance

* ./1-js/08-prototypes/01-prototype-inheritance

So should we remove all directories except the first two ones here?

iliakan commented 2 years ago

Please see the English variant.

Guess, one of these is a stale one, left from long time ago.

mahdyar commented 2 years ago

Please see the English variant.

Guess, one of these is a stale one, left from long time ago.

Yup, it was the second one. OK, now how does it look?

iliakan commented 2 years ago

Yep, fixed. Please, take a look at this duplicate:

mahdyar commented 2 years ago

Yep, fixed. Please, take a look at this duplicate:

* ./9-regular-expressions/06-regexp-unicode

* ./9-regular-expressions/03-regexp-unicode

Done.

iliakan commented 2 years ago

In Disqus (comment system) there's no Farsi/Persian language choice.

There's Arabic, though. Should I set Arabic?

P.S. I know it's a very different language, just wondering... I can set English. There's also Tajik.

mahdyar commented 2 years ago

In Disqus (comment system) there's no Farsi/Persian language choice.

There's Arabic, though. Should I set Arabic?

P.S. I know it's a very different language, just wondering... I can set English.

There's also Tajik.

I use English in my own website. And yes, you're right. They're very different and people here know English much better than Arabic.

iliakan commented 2 years ago

Please, take a look: https://fa.javascript.info/

mahdiHash commented 2 years ago

Please, take a look: https://fa.javascript.info/

2022-09-11_151346

I guess these parts weren't inside the locale.zip that you uploaded here. Is there any way we translate them, too?

iliakan commented 2 years ago

They are inside the tutorial repo. Duly noted, they should be translated indeed ;)

mahdiHash commented 2 years ago

We'll work on it then. Thank you @iliakan. The tutorial is awesome!

mahdyar commented 2 years ago

Please, take a look: https://fa.javascript.info/

Hi; It looks good, but here's some suggestions/problems I see:

  1. Is it possible to add a Persian font to the site? Vazirmatn for example.

  2. The search doesn't work at all and returns a 500 error. [+]

  3. The search icon in the menu, when you click on it, makes a horizontal scroll:

Screen Recording 2022-09-11 at 21 32 48

  1. Is it possible to change the English Discord chat to our Persian Telegram group chat?

  2. And if it's possible, please update the translated phrases:

mahdiHash commented 2 years ago

I agree with Mahdyar. The Vazirmatn font style is much better and more readable than the default one. It would be great if you change it.

mahdiHash commented 2 years ago

2022-09-11_221645

Could we have articles numbers at right of its name? This way, it'll make more sense to the readers.

iliakan commented 2 years ago

Site search - I'm working on it.

For website styling - could you please install https://github.com/iliakan/javascript-tutorial-server and run the tutorial locally, change what's wrong in styles?

mahdiHash commented 2 years ago

Hi, @iliakan.

It seems like the fa.javascript.info isn't sync with the Persian repository. There are some updates in the repo, but can't be seen in the website. Can you check it out to see what's wrong?

Also, we have changed the locales.zip content. Could you update it for the website, please? @mahdyar has uploaded it here.

iliakan commented 2 years ago

Yes, thanks.

Waiting for advise on what to fix on site styles. The javascript-tutorial/server is a simpler repo, but fixes there are acceptable too.

mahdiHash commented 2 years ago

Yes, thanks.

  • Updated locales.
  • Created webhook for autoupdate from the repo.

Waiting for advise on what to fix on site styles. The javascript-tutorial/server is a simpler repo, but fixes there are acceptable too.

We'll inform you about styles. Thank you for the fixes.

mahdiHash commented 2 years ago

Hi, @iliakan.

Currently we can't work on the styles. When the time comes for the changes, we'll let you know.