javascript-tutorial / en.javascript.info

Modern JavaScript Tutorial
https://javascript.info
Other
23.13k stars 3.84k forks source link

Fix grammar and typos #3628

Closed nakhodkin closed 5 months ago

smith558 commented 5 months ago

Thank you for your contribution! 🙂

joaquinelio commented 5 months ago

(Warning I'm not English native speaker)

PLEASE @iliakan @smith558

I agree with most fixes but I think "A quick glance" "You really know" "Clearly communicate" "Your own mind" Really emphasizes ideas, if you take those "superfluous" words off they sound more silly and forgettable, next fix would be to take off the entire sentence and transform the tutorial in just a structured reference.

joaquinelio commented 5 months ago

about "Agree on terms within your team and in your own mind." It's subtle. If you erase "own", the implicit warning is no more. The warning, people working alone tend to relax rules. It is evident when reading the aricle, not so when correcting out of context sentences.

smith558 commented 5 months ago

your own

"your team" implies, in fact, semantically requires that the team is his/her own. Therefore "your own" should not be necessary. (source) It is in most cases used purely for emphasis. Do you feel it's necessary here?

In the case of "quick glance", "really know", "clearly communicate" and likewise. I would say in this article the modifiers in these phrases do not serve a clear purpose and mostly clutter the sentences. Let me know what you think! 🙂

These are definitely good points.

joaquinelio commented 5 months ago

It's ok the lint command, but our languages don't require minifiers 😄

I liked "Buy your food" "Buy your own food" the last implies some reproval. You could avoid "own", but if you say it aloud, you would say "Buy YOUR food" with maybe an accusatory finger. Expressiveness is the key.

I don't thing they clutter sentences. Wrong grammar does.

joaquinelio commented 5 months ago

Sorry Too much debate for a style topic

I would say focus on real grammar issues, there are many of them.