search

javascript-tutorial / en.javascript.info

Modern JavaScript Tutorial
https://javascript.info
Other
23.13k stars 3.84k forks source link

fix square brackets #3656

Closed mikayel00 closed 6 months ago

mikayel00 commented 6 months ago

if descriptors are optional, fixing the parameters in the method will be correct. For example this page -> https://javascript.info/json . Here you can find let json = JSON.stringify(value[, replacer, space]) line, where replacer, spaces are optional.

CLAassistant commented 6 months ago

CLA assistant check
All committers have signed the CLA.

smith558 commented 6 months ago

@mikayel00 found the same mistake here as well https://javascript.info/json#json-parse

mikayel00 commented 6 months ago

@smith558 I can change it too

smith558 commented 6 months ago

@mikayel00 happy to merge after the CLA goes through

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

mikayel00 commented 6 months ago

I signed CLA, but it's still pending.

smith558 commented 6 months ago

Np then, will merge.

smith558 commented 6 months ago

Thank you for your contribution! 🙂

mikayel00 commented 6 months ago

@smith558 Thank you too!