javascript-tutorial / en.javascript.info

Modern JavaScript Tutorial
https://javascript.info
Other
23.44k stars 3.85k forks source link

Fixed image display issue + smart header issue #3683

Closed engag1ng closed 5 months ago

engag1ng commented 5 months ago
CLAassistant commented 5 months ago

CLA assistant check
All committers have signed the CLA.

smith558 commented 5 months ago

@engag1ng Hi! The iframes are loading just fine for me. Could you provide more details/screenshots of what's not working for you?

engag1ng commented 5 months ago

image This is another thing with the HTML code not loading from src.

image This is how every iframe looks for me.

I already tried to open the repo with another browser (Chrome) because I thought that Brave was maybe blocking iframes but no success. Seems like nothing with a src tag loads.

joaquinelio commented 5 months ago

About smart header 4 backticks

Did you test it? There are 4 for a reason, they are nested blocks. There's a big smart box that includes smaller 3 tick code blocks. Nested blocks dont work in github, that's why you need to test it in a local server

smith558 commented 5 months ago

About smart header 4 backticks

Did you test it? There are 4 for a reason, they are nested blocks. There's a big smart box that includes smaller 3 tick code blocks. Nested blocks dont work in github, that's why you need to test it in a local server

Good catch!

engag1ng commented 5 months ago

About smart header 4 backticks

Did you test it? There are 4 for a reason, they are nested blocks. There's a big smart box that includes smaller 3 tick code blocks. Nested blocks dont work in github, that's why you need to test it in a local server

What do you mean with local server? You mean clone it locally and open it in a Markdown viewer? On that topic, any recommendations for MD Viewers?

engag1ng commented 5 months ago

My bad. Didn't realise that you shouldn't view this on GitHub but rather on the website. Closing now. But thanks for the quick support :)

smith558 commented 5 months ago

@engag1ng Thanks for your effort anyway! 🙂

joaquinelio commented 5 months ago

https://github.com/javascript-tutorial/server

Good luck! @engag1ng

As a Spanish turorial maintainer, I Did my part, there and here, with both successful and rejected contribs.