search

javascript-tutorial / hy.javascript.info

Modern JavaScript Tutorial in Armenian
https://javascript.info
Other
9 stars 9 forks source link

Comparisons #81

Closed ArMinasyan closed 3 years ago

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

bugron commented 3 years ago

@ArMinasyan thanks for the PR. I'll review it until Monday. One tiny note for now. PR titles should exactly match article names as specified in https://github.com/javascript-tutorial/hy.javascript.info/issues/1. That way our bot will automatically edit that issue's description so we can track which article is translated in which PR.

javascript-translate-bot commented 3 years ago

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review :ghost:

javascript-translate-bot commented 3 years ago

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review :ghost:

bugron commented 3 years ago

@ArMinasyan thanks for the changes. Couple of things to note. Please do not resolve conversations. Maintainers/reviewers will take care of that. Also when ready to request a new review from a maintainer just add a comment as follows:

/done

Our bot will then take care of notifying appropriate people and will re-request a review. Thanks.

bugron commented 3 years ago

@ArMinasyan we're generally getting closer to merging this PR. I'll give it another round of review after you fix all formatting issues (like missing or having extra new lines) and typos. Thank you.

ArMinasyan commented 3 years ago

done

bugron commented 3 years ago

@ArMinasyan any progress on this PR? Do you need any help or clarification? Thanks.

ArMinasyan commented 3 years ago

Nope, I will review the changes again

javascript-translate-bot commented 3 years ago

Thank you :sparkling_heart: I updated the Progress Issue #1 :tada: :tada: :tada:

bugron commented 3 years ago

@ArMinasyan I've fixed a few things and merged your PR. Thanks for your contribution!