search

javascript-tutorial / hy.javascript.info

Modern JavaScript Tutorial in Armenian
https://javascript.info
Other
9 stars 9 forks source link

Logical operators #82

Closed vahmelk99 closed 3 years ago

vahmelk99 commented 3 years ago

Please check my translation.

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

bugron commented 3 years ago

Thanks for the PR @vahmelk99. I'll be reviewing it soon.

javascript-translate-bot commented 3 years ago

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review :ghost:

bugron commented 3 years ago

@vahmelk99 also for future PRs the name of the PR should exactly match the title of the article you are translating (see https://github.com/javascript-tutorial/hy.javascript.info/issues/1). For example the title of this PR should have been Logical operators.

vahmelk99 commented 3 years ago

@vahmelk99 also for future PRs the name of the PR should exactly match the title of the article you are translating (see #1). For example the title of this PR should have been Logical operators.

Should I create a new PR?

bugron commented 3 years ago

@vahmelk99 nope, just have that noted for future PRs. Thanks.

vahmelk99 commented 3 years ago

Please review my translation one more time. Thank you for your time. Hope I don't miss anything) /done

bugron commented 3 years ago

@vahmelk99 it seems that you need to sign the CLA. That's a routine for this project.

vahmelk99 commented 3 years ago

/done

bugron commented 3 years ago

Did you sign the CLA? Because GitHub still shows you didn't.

image
javascript-translate-bot commented 3 years ago

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review :ghost:

vahmelk99 commented 3 years ago

@bugron thanks for your time.

vahmelk99 commented 3 years ago

/done

bugron commented 3 years ago

@vahmelk99 thanks for your efforts but unfortunately not all the comments are addressed. GitHub might hide some of them so please make sure everything is in order before we can move on to merging this PR. Thanks.

vahmelk99 commented 3 years ago

@vahmelk99 looks superb! Thanks again for your contribution! I've fixed a few line shifts and svg translation stuff and we're ready to merge this PR.

In the SVG file, I fixed the coordinates of the text, so there were not any overflowed texts.

bugron commented 3 years ago

@vahmelk99 the thing is that SVG file should not be modified directly, there is a note about that in README.md. A special images.yml file is used to define SVG text translations and text positions. But its a bit tricky to see the results here because you'll also need to set up the server, run a gulp job to generate new images based on that yml file and start the project (local version of javascriptinfo.com) to check whether everything looks as intended or not. Cheers.