javascript-tutorial / pl.javascript.info

Modern JavaScript Tutorial in Polish
https://javascript.info
Other
38 stars 30 forks source link

Polish Translation Progress #1

Open iliakan opened 5 years ago

iliakan commented 5 years ago

Maintainer List

@deivuss331, @poplaw, @akowalska622, @Onxi95, @RafalMichniuk

For New Translators

Please read this first (click to open)

To translate an article: 1. Check that no one else has claimed your article in the checklist below. 2. Comment below with the title of the article that you would like to translate, exactly as listed, e.g. `An Introduction to JavaScript`. - Please take only one article at a time. 3. Fork this repo, translate the article in your fork and submit a pull request! - The pull request title should be same as the article, e.g. `An Introduction to JavaScript` (just like comment) Please be prompt with your translations! If you find that you can't commit any more, let maintainers know so they can assign the page to someone else.

For Maintainers

Click to open

We recommend that a translation has 2 reviews to be merged. Please let others know what you do, on community boards and chats, invite them to join. Translations become better if more people see them. Translations are tracked below, like this: * [ ] [Home Page](url) (@iliakan) #1 Our helpful bot watches comments and adds the translator nick and PR id, marks completed, when PR is merged. You can read the details at . If something doesn't work right, please contact @iliakan.

Team translation

More details about team translation: https://javascript.info/translate/bot.

Only maintainers can check/uncheck items below. If you're not, please write in a comment what you take to translate, the title, exactly as in the list.

The JavaScript language

An introduction

JavaScript Fundamentals

Code quality

Objects: the basics

Data types

Advanced working with functions

Object properties configuration

Prototypes, inheritance

Classes

Error handling

Promises, async/await

Generators, advanced iteration

Modules

Miscellaneous

Browser: Document, Events, Interfaces

Document

Introduction to Events

UI Events

Forms, controls

Document and resource loading

Miscellaneous

Frames and windows

Binary data, files

Network requests

Storing data in the browser

Animation

Web components

Regular expressions

justdzasta commented 5 years ago

I would like to translate the The modern mode, "use strict"

aleksanderkrauze commented 5 years ago

OK, go ahead @justdzasta

Verthon commented 5 years ago

I would like to translate the Data types

JanKesek commented 5 years ago

i can translate Document in Browser: Document, Events, Interfaces, starting with Browser environment, specs

ghost commented 5 years ago

I would like to translate Hello World!.

effhAVE commented 5 years ago

Variables

Verthon commented 5 years ago

Interaction: alert, prompt, confirm

JanKesek commented 5 years ago

Generators

bartek7 commented 5 years ago

The next for me is Operators and Comparisions

bartek7 commented 5 years ago

@iliakan @aleksanderkrauze Do you need more "Maintainers"? I can be one. And there are 9 pull requests. We should review pull requests more often.

acrolisnun commented 5 years ago

If no one has started on the Objects topic yet I can translate the first three subtopics : Objects, Garbage collection and Symbol type.

bartek7 commented 5 years ago

@iliakan @aleksanderkrauze Can we create a Discord or something like that to communicate with each other?

matwjablonski commented 5 years ago

Hi, can I join to this project and help you? :)

matwjablonski commented 5 years ago

I will take Prototypes, inheritance :)

Versoo commented 5 years ago

Conditional operators: if, '?'

mitroc commented 5 years ago

Hi guys, is this project still alive? 11 PRs, some from July... Do we have some Slack channel or something?

iliakan commented 5 years ago

@bartek7 @mitroc should I assign you as maintainers? Looks like the original maintainer @aleksanderkrauze isn't online any more.

mitroc commented 5 years ago

@iliakan Me, a maintainer? Sounds like a VIP :). But seriously, thanks, but I'm not that good at JavaScript. I will gladly translate some simpler concepts, but I will not undertake to review those that I do not understand myself.

iliakan commented 5 years ago

The translation does not have maintainers now, as I see it.

jakubdrozdek commented 5 years ago

@iliakan Hello there! I'd like to help with translating the docs into Polish. I'm the main maintainer of Polish translation repo for the official React docs (https://pl.reactjs.org). We've created a glossary there, so I guess I might help with jump-starting the translation process here. You may add me as a maintainer here if you like. Cheers!

iliakan commented 5 years ago

@jakubdrozdek Hey, great to hear from you!

We really need a maintainer here. Added you, invite sent.

P.S. You might want to add the glossary link to the Readme.

iliakan commented 5 years ago

@jakubdrozdek We have a bot to ensure double-review of translations. When changes are requested, it adds a label, making PRs easier to filter.

The original bot idea was from react translate bot.

Until we have more reviewers, you can just merge instead of "approving changes". Still, if we get double reviews, that would make the translation quality better.

jakubdrozdek commented 5 years ago

@bartek7 @JanKesek @Verthon @effhAVE Your PRs are still on the list, waiting for a review or merge. Are you willing to correct any mistakes and will you help with the further translation? Or can I copy/paste your translation and mark the article as translated by you (on the list in this issue). I'm asking because your PRs were created in your forked repos and I can't modify them in any way.

jakubdrozdek commented 5 years ago

@iliakan Thanks for the explanation. I've got a question: how am I supposed to mark any items on the list as done? I don't have the permission to edit it, and all of the checkboxes are disabled. Any ideas? In the React repo I had full access to the repo, so I could edit anything.

iliakan commented 5 years ago

@jakubdrozdek if a PR was created as a fork of this repo, you can pull the relevant branch and merge it locally, so there's no need to copy-paste.

Did you receive the github invite to join the org? If you did and joined, you have the access.

jakubdrozdek commented 5 years ago

You're right, it worked :-) I've just accepted the invitation.

mitroc commented 5 years ago

I'll take fetch.

jakubdrozdek commented 5 years ago

@iliakan Any plans on hosting the pl domain soon?

iliakan commented 5 years ago

@jakubdrozdek there's no point in opening pl in its current almost zero-translated state.

mitroc commented 5 years ago

@jakubdrozdek Can we use polish here or in reviews comments?

jakubdrozdek commented 5 years ago

@mitroc Yeah, I think so. It will make our comments better, more precise and more readable, because we won't mix English and Polish. Let's stick to Polish in PRs, and use English in this thread, since it's more 'public' and serves as the progress indicator for people outside. Using Polish in PRs worked fine in React docs, too.

mitroc commented 5 years ago

Deal.

jakubdrozdek commented 5 years ago

Let's wait for PR reviews for max. 7 days to ensure smooth progress. This means that if somebody creates a PR, some other person reviews it and we still need +1 to pass the PR acceptance rules, I (or any other maintainer) will decide if we should merge it after the week or not. We don't want PRs to wait for months just because there are no active reviewers.

mitroc commented 5 years ago

Sure. And what about the PRs, that have been hanging here for months?

jakubdrozdek commented 5 years ago

I'll review them, correct and ask for review again :-)

mitroc commented 5 years ago

Oh my...

iliakan commented 5 years ago

@jakubdrozdek I guess, right now you can merge PRs single-handedly.

jakubdrozdek commented 5 years ago

@iliakan I guess you are right. I wanted to 'lure' some more maintainers by allowing them to review my translations, but I will probably gain more by simply pushing the translation progress forward.

What are your requirements for creating the pl domain? Do you want us to reach a particular milestone? Maybe I could prioritize some of the articles in order to reach out to the world sooner.

iliakan commented 5 years ago

@jakubdrozdek Surely more maintainers is better, especially with experience from React translation =)

Usually we publish as far as 50% is translated.

iliakan commented 5 years ago

At least part 1 is done.

mitroc commented 5 years ago

FormData

mitroc commented 5 years ago

Guys, this might be a stupid question, but I've almost never made a pull request. Once one PR is in progress I can not make another PR to the same branch, so they are kind of separate? I see that the second PR, which I planned to name FormData was dragged into the first - Fetchm without even giving me the chance to name it... :-/

jakubdrozdek commented 5 years ago

Yeah, this is because PR is an intent to merge some particular branch into another one. And if you create a PR with branch "X", and then add something else to the same branch, it will appear in the PR, too.

You should stick to those rules:

All of those actions can be made with a decent IDE, such as Visual Studio Code. There might be some differences in your flow since you work on a fork of this repo. The main rule is that each PR should be made with a separate branch.

EDIT: I can see that your PR was created to merge your master into this repo's master. image You should avoid making PRs like that and instead create separate branches for each 'feature' (article translation), just like I mentioned above. For now, let's leave it as it is. I'll review your changes and will merge it later. But remember to always create a new branch for each translation :)

EDIT2: Here's a link to an article describing fork flow: https://blog.scottlowe.org/2015/01/27/using-fork-branch-git-workflow/. If you remove your local files and do it step-by-step, you should have a properly set up, ready to work local repo and a bunch of good practices in your belt :)

mitroc commented 5 years ago

Holy crap! Sounds like I screwed thins up. :), but really I made my last PR in 2017 and it was the third one ;). Anyway, @jakubdrozdek thanks for the guide, I'think it might be a good idea to pin your post to the repo description for posterity.

sbielenica commented 5 years ago

Hey, I'd like to translate Comments from Code quality section.

jakubdrozdek commented 5 years ago

Hello, @sbielenica ;-) Welcome aboard.

mitroc commented 5 years ago

Fetch: Abort

ghost commented 4 years ago

Logical operators

TomaszWaszczyk commented 4 years ago

Anyone translates https://github.com/javascript-tutorial/pl.javascript.info/blob/master/1-js/02-first-steps/16-arrow-functions-basics ?

Katolus commented 4 years ago

Hey guys, I would like to help. I can take a section like Introduction to Events if we can divide by sections. If not I will take an item each time a branch gets in. Up to you!