javascript-tutorial / pt.javascript.info

Tutorial de JavaScript Moderno em Português
https://javascript.info
Other
229 stars 111 forks source link

Mixins #382

Closed danilolmc closed 1 year ago

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

odsantos commented 1 year ago

Hi @DaniloLima122 ,

Appreciated your efforts. Under the title For New Translators, on the top of #1 , you may find instructions for claiming the article and naming the pull request.

Would you please follow them? Thanks.

danilolmc commented 1 year ago

Hi @odsantos !

Thank you for the tips!

Now I think the PR name is correct, according the name of the article!

odsantos commented 1 year ago

Hi @DaniloLima122 , it also is necessary to claim it in your name, according to the same instructions, thus you need to add a comment on that page with this title too. After that, if the bot does not reserve on your name and add this PR, a maintainer may do it manually. Thanks.

danilolmc commented 1 year ago

Hi @DaniloLima122 , it also is necessary to claim it in your name, according to the same instructions, thus you need to add a comment on that page with this title too. After that, if the bot does not reserve on your name and add this PR, a maintainer may do it manually. Thanks.

Hi @odsantos , thank you! It's done!

odsantos commented 1 year ago

Hi @DaniloLima122 , in the future please do not forget to claim first, then to give the PR the same name as on that page. The bot could reserve it in your name, and usually it can also assign the PR later, but no worries the PR is there as well, done manually. Thanks for your efforts.

danilolmc commented 1 year ago

Hi @DaniloLima122 , in the future please do not forget to claim first, then to give the PR the same name as on that page. The bot could reserve it in your name, and usually it can also assign the PR later, but no worries the PR is there as well, done manually. Thanks for your efforts.

Hi @odsantos ! Great, I won't, thanks for your support! 😁

javascript-translate-bot commented 1 year ago

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review :ghost:

odsantos commented 1 year ago

Hi @danilolmc ,

Here, the bot explains how to indicate that a translation is ready for another review.

Your PR is still marked with "changes requested" under Labels on the top right of this page, which was done by the bot after my review.

Having that label, maintainers might believe that something is still to be done, and not have a look at a PR unless much time has passed.

Since you still might wish to make changes, when you have finished would you tell the bot you're done?

Please, only comment with "/done" here, without quotes or anything else.

Meanwhile, I am afraid I'll wait for that and the subsequent bot request for another review.

Thank you, Osvaldo.

danilolmc commented 1 year ago

/done

javascript-translate-bot commented 1 year ago

Error: the article has another translator @DaniloLima122, not @danilolmc in the Progress Issue #1. Please update the progress issue or ask maintainers to do so.

jonnathan-ls commented 1 year ago

Error: the article has another translator @DaniloLima122, not @danilolmc in the Progress Issue #1. Please update the progress issue or ask maintainers to do so.

Updated

danilolmc commented 1 year ago

Error: the article has another translator @DaniloLima122, not @danilolmc in the Progress Issue #1. Please update the progress issue or ask maintainers to do so.

Updated

I had changed my github username, but I had already finished the translation before it was merged.