javascript-tutorial / pt.javascript.info

Tutorial de JavaScript Moderno em Português
https://javascript.info
Other
229 stars 111 forks source link

BigInt #430

Closed danilolmc closed 9 months ago

Peruibeloko commented 9 months ago

@nazarepiedady I'd keep it as BigInt, and the only change I'd suggest is to capitalize it, since we're dealing with the actual object's name, much like we shouldn't translate Promise to Promessa for example :)

danilolmc commented 9 months ago

I agree with @Peruibeloko, since BigInt is just like Promise and the data type name itself.

@Peruibeloko do you mean capitalize every bigint word in the article? I just let some bigint words as it was already capitalized.

Peruibeloko commented 9 months ago

@danilolmc Yes, that would be the case. Just a suggestion, of course.

danilolmc commented 9 months ago

Ok, no problem, I'm going to capitalize them!

nazarepiedady commented 9 months ago

@nazarepiedady I'd keep it as BigInt, and the only change I'd suggest is to capitalize it, since we're dealing with the actual object's name, much like we shouldn't translate Promise to Promessa for example :)

@Peruibeloko, I was talking about to translate the usage of the word bigint where it is not reference the data type.

Peruibeloko commented 9 months ago

@nazarepiedady the problem is that bigint always refers to the data type

javascript-translate-bot commented 9 months ago

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review :ghost:

danilolmc commented 9 months ago

/done

odsantos commented 9 months ago

I agree with @Peruibeloko, since BigInt is just like Promise and the data type name itself.

@Peruibeloko do you mean capitalize every bigint word in the article? I just let some bigint words as it was already capitalized.

Seems good, as the Portuguese 'mdn' link, and other accepted suggestions here.

javascript-translate-bot commented 9 months ago

Thank you :sparkling_heart: I updated the Progress Issue #1 :tada: :tada: :tada: