javascript-tutorial / server

Server for the Modern Javascript Tutorial
https://javascript.info
Other
452 stars 138 forks source link

binaries can't be found error #45

Closed Violet-Bora-Lee closed 5 years ago

Violet-Bora-Lee commented 5 years ago

After the pngs are changed svgs, I've got such error.

image

The reason for the error is that the server searches the image files in en directory not ko directory(in my case). You can see the error message on the image.

iliakan commented 5 years ago

How can I reproduce that?

Violet-Bora-Lee commented 5 years ago

You could reproduce the issue deleting en directory in your local machine and only set foreign project such as ko, I guess.

Violet-Bora-Lee commented 5 years ago

I may need to add this issue on the engine repository. It's time to look around server-side codes for me.

iliakan commented 5 years ago

I can do that. Delete English and run ./edit ko?

Violet-Bora-Lee commented 5 years ago

Yes :)

iliakan commented 5 years ago

And then...? Should I re-translate an image or edit an article?

Violet-Bora-Lee commented 5 years ago

No. You could reproduce the issue when you delete en directory and have another directory but en on local machine. Couldn't you reproduce the issue?

iliakan commented 5 years ago

I deleted English folder. Then run ./edit ru (shouldn't matter).

Then everything was ok.

Maybe I need to do something else.

Violet-Bora-Lee commented 5 years ago

Oh, I see. I'll try other languages but Korean.

iliakan commented 5 years ago

I will try korean.

iliakan commented 5 years ago

image

iliakan commented 5 years ago

Most likely, you don't have imagemagick installed. =)

iliakan commented 5 years ago

Need help with that?

Violet-Bora-Lee commented 5 years ago

I'm using Windows 10 and Chocolatey, package manager for Windows. I've installed graphicsmagick and imagemagick using Chocolatey but had the same issue. I've also tried to install both packages by installing binary files. Phew :( :(

I'll try more to resolve the issue on my local machine. Anyway, I can see that it's not the problem comes from your code but mine.

Thanks for your trying 👍

Violet-Bora-Lee commented 5 years ago

[for Windows 10 user]

GraphicsMagick Download Link: ftp://ftp.graphicsmagick.org/pub/GraphicsMagick/windows/ ImageMagick Download Link: http://www.imagemagick.org/script/download.php#windows

The cause of the issue comes from ImageMagick.

image

When you install ImageMagick, there are some default checked boxes like the image above. When you haven't touched anything and keep installing, the same issue will occur.

image

So, I've set like this and the issue no longer has occurred.