search

javascriptdata / dnotebook-react

React version of Dnotebook
16 stars 3 forks source link

CSS Framework [Suggestion] #10

Open steveoni opened 3 years ago

steveoni commented 3 years ago

@AceTheCreator I will suggest we make use of tailwind css to ease prototyping. I've set up the tailwind configuration and everything needed to enable tailwind

AceTheCreator commented 3 years ago

@steveoni i don't think that'll be necessary because the UI has been done already. I was planning on submitting a pull request today but I'm having issue with my Pc. The only thing remaining is just the default functions output. E.g. Load_csv, load_package e.t.c.

steveoni commented 3 years ago

ok, if that so, you can just pull and discard my changes.

and for the load_csv and load_package, we can easily copy and paste that from the Dnotebook itself into this current version.

AceTheCreator commented 3 years ago

@steveoni sorry for the delay on the project. I just got my system fixed today, so i'll hop on the project ASAP

AceTheCreator commented 3 years ago

@steveoni I'm really sorry for the projects delay, I had some personal issue that made me put a pause on the project last month. I'm fully back now and I've continued working on it.

AceTheCreator commented 3 years ago

@steveoni i was thinking should there be a message when a package successfully loads or it should just be blank as seen below in cell one. Screenshot from 2021-03-09 22-53-54

steveoni commented 3 years ago

@steveoni I'm really sorry for the projects delay, I had some personal issue that made me put a pause on the project last month. I'm fully back now and I've continued working on it.

Hi @AceTheCreator , how you doing, hope it is not something too critical. Great to hear from you again

steveoni commented 3 years ago

@steveoni i was thinking should there be a message when a package successfully loads or it should just be blank as seen below in cell one. Screenshot from 2021-03-09 22-53-54

That will be okay. But we can also have a spinner to indicate the file is loading. Awesome work. you create a pull request for this

AceTheCreator commented 3 years ago

@steveoni I'm really sorry for the projects delay, I had some personal issue that made me put a pause on the project last month. I'm fully back now and I've continued working on it.

Hi @AceTheCreator , how you doing, hope it is not something too critical. Great to hear from you again

Thanks man

AceTheCreator commented 3 years ago

@steveoni i was thinking should there be a message when a package successfully loads or it should just be blank as seen below in cell one. Screenshot from 2021-03-09 22-53-54

That will be okay. But we can also have a spinner to indicate the file is loading. Awesome work. you create a pull request for this

Ok. I'll implement the features mentioned above and create a pull request.

AceTheCreator commented 3 years ago

@steveoni implemented the feature mentioned above.

risenW commented 3 years ago

@AceTheCreator My bad, I'm just seeing this update now. Great work! I just saw your PR. @steveoni will review and merge.