javascriptdata / dnotebook-react

React version of Dnotebook
16 stars 3 forks source link

Add ploty functionality #14

Closed AceTheCreator closed 3 years ago

AceTheCreator commented 3 years ago

Dnotebook plot functionality is not yet implemented

AceTheCreator commented 3 years ago

@steveoni @risenW is there a built in plotting functionality in danfojs or an external library is been you use when plotting?

risenW commented 3 years ago

We support Plotly graph, so the plot functions basically uses Plotly (When it is installed) to make charts. Plot works when they're are supplied a dom element: See: https://dnotebook.jsdata.org/getting-started and https://danfo.jsdata.org/api-reference/plotting/line-charts

AceTheCreator commented 3 years ago

Ok, I've implemented it I'll submit a pull request closing this issue tomorrow.

AceTheCreator commented 3 years ago

@risenW I've created a PR that will close this issue