search

javascriptdata / dnotebook-react

React version of Dnotebook
16 stars 3 forks source link

feat: added default note on render #20

Closed AceTheCreator closed 3 years ago

AceTheCreator commented 3 years ago

This PR also fixed cell id duplication and uncompleted note data when downloaded.

risenW commented 3 years ago

@AceTheCreator Greate work! One issue though, I pulled this branch, fixed the merge conflict and tested locally, but when I run start, I get an empty page with no action button:

Screen Shot 2021-05-30 at 4 14 34 PM

Do take a look, once you fix this, I'll merge. Also, I added github ci test

AceTheCreator commented 3 years ago

@risenW I didn't know what should be in the getting started page, that was why i left it empty.

risenW commented 3 years ago

@risenW I didn't know what should be in the getting started page, that was why i left it empty.

The first page is to open with a single code cell. So the user can start working from there.

AceTheCreator commented 3 years ago

@risenW I didn't know what should be in the getting started page, that was why i left it empty.

The first page is to open with a single code cell. So the user can start working from there.

I'd get that done.