search

javascriptdata / dnotebook-react

React version of Dnotebook
16 stars 3 forks source link

Navigation Bar #3

Closed AceTheCreator closed 3 years ago

AceTheCreator commented 3 years ago

Need someone to implement the navigation bar. P.S. It must be responsive.

folafunmi-db commented 3 years ago

I volunteer, I can get it done on Monday but where would I push it to? And do you suggest CRA or NextJS? Also would you prefer vanilla css, sass or tailwind?

folafunmi-db commented 3 years ago

Also, am I to include a theme switched for dark mode, if so where do I put it? And do I assume that the responsive layout would substitute the nav links with a hamburger menu? Because it's not shown in the Figma file.

AceTheCreator commented 3 years ago

@folafunmi-db I'm waiting for @steveoni to make me a contributor to the project's repo in other to lead the project.

steveoni commented 3 years ago

@alphabet-codes I will.

steveoni commented 3 years ago

@alphabet-codes I sent an invite

AceTheCreator commented 3 years ago

@folafunmi-db you can start working on this issue now. The styles should be writing in CSS-IN-JS, fork the project's repo in other to get started.

folafunmi-db commented 3 years ago

I'd get started this week, just need to finish up something else for. Also, I assume we're using CRA and not Next JS?

steveoni commented 3 years ago

@alphabet-codes @folafunmi-db any progress update? Any blockers and what's the timeline for the project completion, cause we need a major milestone on this before this weekend.

AceTheCreator commented 3 years ago

I'd get started this week, just need to finish up something else for. Also, I assume we're using CRA and not Next JS?

@folafunmi-db fork the project's repo it's bootstrapped by CRA

AceTheCreator commented 3 years ago

@alphabet-codes @folafunmi-db any progress update? Any blockers and what's the timeline for the project completion, cause we need a major milestone on this before this weekend.

@steveoni I'm currently working on it and I'll submit a pull request tomorrow and there's no blockers for now. I'll ensure there's a major milestone before the week runs out.

folafunmi-db commented 3 years ago

@alphabet-codes I've submitted a pull request, please review.