ferrys
commented
6 years ago Hi @thomasritscher, I've merged this PR. I'm going to close the other one you referred to and have this released soon
Closed thomasritscher closed 6 years ago
ferrys
commented
6 years ago Hi @thomasritscher, I've merged this PR. I'm going to close the other one you referred to and have this released soon
According to commit in: https://github.com/javaswift/joss/pull/90/commits/105f70c8d4a3409b5de3504ba3eb07444f8b607c Solution is basically the same, but as there was no response in the last one and a half years in the original pull request and the problem still persists, I resubmitted this one.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I have the right to submit it under the Apache License 2.0; or
(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or
(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.
(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.
DCO 1.1 Signed-off-by: Thomas Ritscher