feat(#12): Cache changes on webserver

javatarz / github-contribution-leaderboard

Helps build a Hacktoberfest leaderboard on command line

Apache License 2.0

5 stars 10 forks source link

feat(#12): Cache changes on webserver #40

Closed sathia27 closed 5 years ago

sathia27 commented 5 years ago

Add details of your PR here..

Checklist

[x] Have you followed the guidelines for contributing?
[x] Have you checked that there aren't other open pull requests for the same feature you're adding?
[x] Have you run tests (pipenv run pytest) before sending this PR?
[x] Have you run linting (./lint.sh) before sending this PR?

javatarz commented 5 years ago

Hey @sathia27, thank you for your contribution! I noticed you're importing redis but it isn't mentioned in the Pipfile. The Pipfile is what ensures all python dependencies are installed consistently on all machines. If you run pipenv install redis, it'll update the Pipfile and Pipfile.lock.

This is also a good opportunity for you to send another PR to update the contribution.md file about this so future contributors know they should be doing this :) I'll create an issue for this.

sathia27 commented 5 years ago

@javatarz Thank you for your quick response

Made few other changes as you mentioned.

pipfile changes related to importing redis - Done
removed constant for cache duration. Use args instead of constant - Done
changes to contribution.md, regarding importing new package.
- PR: #42