javer / JaverSphinxBundle

Symfony bundle which provides integration of Sphinx search engine with Symfony using SphinxQL
MIT License
24 stars 19 forks source link

Add Symfony 4 examples #3

Open tacman opened 6 years ago

tacman commented 6 years ago

Use Dependency Injection instead of the container.

peter-gribanov commented 6 years ago

@tacman this code in your PR is not working

use Javer\SphinxBundle\Sphinx\Manager;
use Knp\Component\Pager\Pagination\PaginationInterface;
use Doctrine\ORM\EntityManagerInterface;
     public function __construct(EntityManagerInterface $em, 
                                PaginatorInterface $paginator,
                                Manager $sphinx)

    private $sphinx;
    private $em;
    private $paginator;

    {
        $this->sphinx = $sphinx;
        $this->em = $em;
        $this->paginator = $paginator;
    }

Do you declare the global function __construct()? Maybe this is a class code? Why do you declare properties in the middle of a function/method declaration?

tacman commented 6 years ago

Yeah, you're right -- cut and paste was wrong. Sigh.

On Mon, Dec 3, 2018 at 10:05 AM Peter Gribanov notifications@github.com wrote:

@tacman https://github.com/tacman this code in your PR is not working

use Javer\SphinxBundle\Sphinx\Manager;use Knp\Component\Pager\Pagination\PaginationInterface;use Doctrine\ORM\EntityManagerInterface; public function __construct(EntityManagerInterface $em, PaginatorInterface $paginator, Manager $sphinx) private $sphinx; private $em; private $paginator; { $this->sphinx = $sphinx; $this->em = $em; $this->paginator = $paginator; }

Do you declare the global function __construct()? Maybe this is a class code? Why do you declare properties in the middle of a function/method declaration?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/javer/JaverSphinxBundle/pull/3#issuecomment-443741737, or mute the thread https://github.com/notifications/unsubscribe-auth/AAl0Qcz1zsOWmr_1BTDp4OdAhAeVpusOks5u1T3TgaJpZM4Y-Yfn .

tacman commented 6 years ago

OK, I've fixed that now.

On Mon, Dec 3, 2018 at 11:31 AM Tac Tacelosky tacman@gmail.com wrote:

Yeah, you're right -- cut and paste was wrong. Sigh.

On Mon, Dec 3, 2018 at 10:05 AM Peter Gribanov notifications@github.com wrote:

@tacman https://github.com/tacman this code in your PR is not working

use Javer\SphinxBundle\Sphinx\Manager;use Knp\Component\Pager\Pagination\PaginationInterface;use Doctrine\ORM\EntityManagerInterface; public function __construct(EntityManagerInterface $em, PaginatorInterface $paginator, Manager $sphinx) private $sphinx; private $em; private $paginator; { $this->sphinx = $sphinx; $this->em = $em; $this->paginator = $paginator; }

Do you declare the global function __construct()? Maybe this is a class code? Why do you declare properties in the middle of a function/method declaration?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/javer/JaverSphinxBundle/pull/3#issuecomment-443741737, or mute the thread https://github.com/notifications/unsubscribe-auth/AAl0Qcz1zsOWmr_1BTDp4OdAhAeVpusOks5u1T3TgaJpZM4Y-Yfn .