javer / gentoo-overlay

Gentoo Portage Overlay [javer]
9 stars 11 forks source link

Fix gcc version check #15

Closed anthonyryan1 closed 10 years ago

anthonyryan1 commented 10 years ago
anthonyryan1 commented 10 years ago

Since I'm evaluating HHVM and Hacklang for deployment this Summer, I'm willing to work on the parts of this overlay that will be affecting me. Before I begin on that I have a couple questions.

javer commented 10 years ago

Thanks for your work!

gcc should never be have been a runtime dependency, as it's only ever used for compiling

Not sure in case with hhvm:

$ ldd hhvm
     libstdc++.so.6 => /usr/lib/gcc/x86_64-pc-linux-gnu/4.8.2/libstdc++.so.6 (0x00007fc8f94c4000)
     libgcc_s.so.1 => /usr/lib/gcc/x86_64-pc-linux-gnu/4.8.2/libgcc_s.so.1 (0x00007fc8f8fb9000)
     libgomp.so.1 => /usr/lib/gcc/x86_64-pc-linux-gnu/4.8.2/libgomp.so.1 (0x00007fc8f82dd000)

$ qfile /usr/lib/gcc/x86_64-pc-linux-gnu/4.8.2/libstdc++.so.6
sys-devel/gcc (/usr/lib/gcc/x86_64-pc-linux-gnu/4.8.2/libstdc++.so.6)

$ qfile /usr/lib/gcc/x86_64-pc-linux-gnu/4.8.2/libgcc_s.so.1
sys-devel/gcc (/usr/lib/gcc/x86_64-pc-linux-gnu/4.8.2/libgcc_s.so.1)

$ qfile /usr/lib/gcc/x86_64-pc-linux-gnu/4.8.2/libgomp.so.1
sys-devel/gcc (/usr/lib/gcc/x86_64-pc-linux-gnu/4.8.2/libgomp.so.1)

Do you have any issue with working towards adhering to the guidelines in the Gentoo Developer Handbook?

Nope, you may freely contribute any changes to improve quality of ebuilds.

What is your policy for removing older release ebuilds? This will not harm anyone who still has an older version installed, but will prevent new installations of these old versions.

I will remove pre-previous major releases, so 2.x tree will be removed when 4.0 major version is released. This policy is subject to change in the future.

Please note, your PR should be rebased on top of the master due to the latest changes.

anthonyryan1 commented 10 years ago

I did some greping through the hhvm source and read up a bit on those libraries. They're runtime dependencies added by gcc and not runtime dependencies from the hhvm source. Many other binaries of comparable complexity on your system will turn up the same things when you run ldd against them.

Additionally, the handbook says dependencies on gcc are implicit

anthonyryan1 commented 10 years ago

I have sorted out the branch mixup and again put gcc changes only into this pull request, sorry about the trouble.

javer commented 10 years ago

Thanks!