search

javierbrea / eslint-plugin-boundaries

Eslint plugin checking architecture boundaries between elements
MIT License
473 stars 9 forks source link

Remove `is-core-module` dependency #335

Open wojtekmaj opened 3 days ago

wojtekmaj commented 3 days ago

Please provide enough information so that others can review your pull request:

Node.js from v6.13.0, v8.10.0, v9.3.0 includes module.builtinModules which we can use to natively check if some module belongs to Node.js core or not.

This drops not one, but three dependencies, removing 70 KB of bloat: https://npmgraph.js.org/?q=is-core-module

Closing issues

Closes #334

javierbrea commented 2 days ago

Hi @wojtekmaj , First of all, thanks for your contribution! 😃

Could you please add some test? I suppose that adding a pair of tests checking that importing both types of core modules is valid would be enough (with or without prefix, I suppose, according to the implementation). You could add them to the test function in the test/rules/one-level/element-types.spec.js, for example.

Anyway, just let me know if you need help to run tests locally or whatever.