search

javiereguiluz / easybook

Book publishing as easy as it should be (built with Symfony components)
https://easycorp.io/EasyBook
Other
754 stars 81 forks source link

Remove share method. This method is deleted from pimple. #136

Closed fidelio314 closed 10 years ago

fidelio314 commented 10 years ago

https://github.com/fabpot/Pimple/commit/457742085939b5d095f2a0bba9fed023da9a57be#diff-553037d9adc48bbece4ab185700cf095

fidelio314 commented 10 years ago

oups i think its not for the good version. as i just saw in the composer its used the 1.* pimple version

javiereguiluz commented 10 years ago

If I understand it correctly, the share() method has been deleted from Pimple 2.0. But easybook uses Pimple 1.1.1, so this problem can't happen. Recently I've locked dependencies versions so you can't really end up with Pimple 2.0 when executing a composer update command.

Please, feel free to reopen this issue if the error happens again or if you think that the cause of the error hasn't been fixed.