search

javiereguiluz / easybook

Book publishing as easy as it should be (built with Symfony components)
https://easycorp.io/EasyBook
Other
754 stars 81 forks source link

[Insight] PHP code should follow PSR-1 basic coding standard #142

Closed javiereguiluz closed 9 years ago

javiereguiluz commented 10 years ago

in src/Easybook/Parsers/EasybookMarkdownParser.php, line 75

Method names should be declared in camelCase. You should rename this class to comply with PSR-1.


    /**
     * Improves the performance of the original method. Copied from:
     * http://github.com/KnpLabs/KnpMarkdownBundle/blob/master/Parser/MarkdownParser.php
     */
    public function _initDetab()
    {
        return;
    }

    /**

There are a lot of similar issues in this class. See analysis report for reference.

Posted from SensioLabsInsight

javiereguiluz commented 9 years ago

Closing it because this file is closely related to our current PHP Markdown parser, which will soon be replaced.