javiergcim / MakeUpUltraFast

High performance Minecraft shader (Java). For a graphical enhancement. Intended for low-spec computers.
GNU Lesser General Public License v3.0
108 stars 39 forks source link

Better Clouds: Clouds directly above you are white at night #108

Open eliasjurkeit opened 3 days ago

eliasjurkeit commented 3 days ago

Minecraft Version 1.20.1

Shader Version 9.0a

Fabric Version 0.16.9

Shader Settings

SIMPLE_AUTOEXP=true BLOOM=false SHADOW_CASTING=false SHADOW_DISTANCE_SLIDER=0 V_CLOUDS=0 VOL_LIGHT=0 AA_TYPE=0 SHADOW_QTY_SLIDER=1 REFLECTION_SLIDER=1 CLOUD_REFLECTION=false

Other Mods Installed

[✔] accelerated-decay-fabric-3.0.1+mc1.20.1 [✔] adv_nuker-1.20-1.4-fabric [✘] advanced-ui-scale-1.2.1-1.20.1.jar (disabled) [✔] alternate-current-mc1.20-1.9.0 [✔] architectury-9.2.14-fabric [✘] audio_engine_tweaks-1.2.5-MC1.20.1 build 2.jar (disabled) [✘] badhorsefix-fabric-2.1.0.jar (disabled) [✔] betterbiomereblend-1.4.2 [✔] better-clouds-1.3.22+1.20.1-fabric [✔] BetterGrassify-1.3.0+fabric.1.20.1 [✔] betterwalls-3.5.1 [✘] blanket-client-tweaks-1.1.4.jar (disabled) [✔] c2me-fabric-mc1.20.1-0.2.0+alpha.11.13 [✘] carpet-fixes-1.20-1.16.1.jar (disabled) [✔] Chunky-1.3.146 [✔] cloth-config-11.1.136-fabric [✘] CollisionFix-1.0.1.jar (disabled) [✔] connectiblechains-2.2.1+1.20.1 [✔] craftsense-1.20.1-v1.0.7 [✔] Cull Less Leaves-1.4.2+1.21-fabric [✘] darkness-fabric-1.2.0+mc1.20.1.jar (disabled) [✔] DiagonalFences-v8.1.4-1.20.1-Fabric [✔] DiagonalWindows-v8.1.4-1.20.1-Fabric [✔] DistantHorizons-2.2.1-a-1.20.1-forge-fabric [✔] enhancedblockentities-0.9+1.20 [✔] entityculling-fabric-1.7.1-mc1.20.1 [✔] exordium-fabric-1.2.1-mc1.20.1 [✔] fabric-api-0.92.2+1.20.1 [✘] fabric-carpet-1.20-1.4.112+v230608.jar (disabled) [✔] fabric-language-kotlin-1.12.3+kotlin.2.0.21 [✔] fasterrandom-5.1.0 [✔] ferritecore-6.0.1-fabric [✔] fishingrodfix-1.20.4-0.3 [✔] ForgeConfigAPIPort-v8.0.0-1.20.1-Fabric [✔] fpsdisplay-3.1.0+1.20.x [✔] fzzy_config-0.5.6+1.20.1 [✔] highlight-fabric-1.20-2.0.1 [✔] Icterine-fabric-1.20.0-1-1.3.0 [✔] indium-1.0.34+mc1.20.1 [✔] iris-1.7.5+mc1.20.1 [✘] iris-flywheel-compat-fabric1.20.1+1.1.4.jar (disabled) [✔] krypton-0.2.3 [✘] lambdynamiclights-2.3.2+1.20.1.jar (disabled) [✔] lithium-fabric-mc1.20.1-0.11.2 [✔] logarithmic-volume-control-1.0.0-1.20.1 [✔] mcfc-0.2.2-alpha.2+1.20.1-fabric [✔] memoryleakfix-fabric-1.17+-1.1.5 [✔] modelfix-1.15-fabric [✔] modmenu-7.2.2 [✔] moonlight-1.20-2.13.25-fabric [✔] moreculling-1.20.4-0.24.0 [✔] noisium-fabric-2.3.0+mc1.20-1.20.1 [✘] owo-lib-0.11.2+1.20.jar (disabled) [✔] particle_core-0.2.5+1.20.1 [✔] PuzzlesLib-v8.1.24-1.20.1-Fabric [✔] quickbench-4.1.0+mc.1.20.1 [✔] RailOptimization-1.20(.1)-1.0 [✔] redstonepen-1.20.1-fabric-1.5.31 [✘] reeses_sodium_options-1.7.2+mc1.20.1-build.101.jar (disabled) [✔] ridingmousefix-1.0.0 [✔] seamless-2.2.2-fabric-1.20.1 [✘] sodiumdynamiclights-fabric-1.0.9-1.20.1.jar (disabled) [✘] sodium-extra-0.5.4+mc1.20.1-build.115.jar (disabled) [✘] sodiumextras-fabric-1.0.6-1.20.1.jar (disabled) [✔] sodium-fabric-0.5.11+mc1.20.1 [✘] sodiumoptionsapi-fabric-1.0.5-1.20.1.jar (disabled) [✘] staaaaaaaaaaaack-fabric-1.20.1-1.5-71.jar (disabled) [✔] starlight-1.1.2+fabric.dbc156f [✔] threatengl-fabric-1.3.3-release.1 [✘] tooltipfix-1.1.1-1.20.jar (disabled) [✘] videotape-1.3.0.jar (disabled) [✘] VulkanMod_1.20.1-0.5.0-build.1.jar (disabled) [✘] worldspecificviewdistance-0.2.1+1.20.jar (disabled) [✔] YetAnotherConfigLib-3.6.1+1.20.1-fabric

Operating System Windows 11

GPU RX 580

Issue Description There's a large square patch above the player where the clouds are rendered white instead grey/black. It follows the player. See screenshots.

Steps to Reproduce

  1. Install Better Clouds mod and this shader.
  2. /set time midnight
  3. Look above you

Here's an MC-Log of a session: https://mclo.gs/NCf2wS0 (just launched and entered a world, not a huge log)

eliasjurkeit commented 3 days ago

Also confirmed this with a clean installation, where only Iris, Sodium, Indium, Better Clouds and ofc this shader was installed.

javiergcim commented 1 day ago

Unfortunately, it seems to me that the effect is the result of a fundamental incompatibility between the mod and the shader, and it's beyond the shader's control to fix the issue. For some reason, the clouds are modified in the same way as the sky, but without considering the Moon/Sun rotation. If you disable the Sun/Moon rotation in the shader's advanced options, that modification will match the one applied to the sky (a glow around the moon).