Water Color "Shader Scheme" Setting Ignored if Vanilla Like Water is Set to "On"

javiergcim / MakeUpUltraFast

High performance Minecraft shader (Java). For a graphical enhancement. Intended for low-spec computers.

GNU Lesser General Public License v3.0

97 stars 37 forks source link

Water Color "Shader Scheme" Setting Ignored if Vanilla Like Water is Set to "On" #30

Open jetblackrx89 opened 2 years ago

jetblackrx89 commented 2 years ago

Using the latest MakeUp-UltraFast-8.5a, if "vanilla like water" is set to "on", setting the "water color" to "shader scheme" doesn't do anything. Other shaders packs with similar options manage to still apply a color transformation even if "vanilla-like" water options are chosen.

I tested this by manually editing the source files to make water neon green. It only applies if "vanilla like water" is set to "off".

javiergcim commented 2 years ago

I am sorry. It is not a fault. That's how it was originally designed a long time ago. But what you say makes sense.

Vanilla mode was literally vanilla mode.

jetblackrx89 commented 2 years ago

No worries. If you're willing to consider this an enhancement request, for something you might return to if you're interested and have the time, I'd be happy enough. Thanks!