search

javiergcim / MakeUpUltraFast

High performance Minecraft shader (Java). For a graphical enhancement. Intended for low-spec computers.
GNU Lesser General Public License v3.0
97 stars 36 forks source link

Water fog becomes just black in caves and it looks weird. #49

Open Dlanis opened 1 year ago

Dlanis commented 1 year ago

screen1 screen2 I think it looks weird.

javiergcim commented 1 year ago

It doesn't seem strange to me. It would be expected: if there is no light everything should become dark. Maybe it's because you're too used to other ways of representing water.

It is also true that the light calculation is approximate and takes advantage of the simple information that Minecraft provides, and there will always be situations where perhaps there should be more (or less) light.

One thing is true though: in Minecraft 1.12 or below the water looks particularly dark. But it's uncontrollable and it's because the render works differently in that version and later ones.

Dlanis commented 1 year ago

For me water is looking strange, because other blocks still lighted, when water becomes black losing its colors. And so I get a sense of inconsistency. I think it would be looking better if water had some sort of ambient lighting like other blocks. And thanks you for such an optimised shaderpack.

p. s. I'm not english native, so I can make mistakes. (I made screenshots using 1.19.4 and iris by the way)