search

javiergcim / MakeUpUltraFast

High performance Minecraft shader (Java). For a graphical enhancement. Intended for low-spec computers.
GNU Lesser General Public License v3.0
97 stars 36 forks source link

Blocking FPS #53

Closed QueenUlyana closed 1 year ago

QueenUlyana commented 1 year ago

MakeUp-UltraFast-8.8d blocks FPS depending on the preset when V-Sync is on. My monitor supports 60Hz, but when I put for example Shadowless Low preset, your shader blocks FPS at 30 frames in V-Sync mode. Of course I could disable V-Sync, but then the picture would be torn, I need V-Sync and 60FPS. How can I remove the FPS blocking in your shader?

javiergcim commented 1 year ago

The shader does not block FPS. If your PC is not able to generate more than 60 FPS with shaders enabled, it is impossible for you to see more than 30 FPS with VSyc enabled, because VSync will always wait to paint on screen until an animation frame is finished, and if the machine does not finish a frame in 1/60th of a second, it will wait for the next one, that is 30 FPS.

But if your PC is capable of generating more than 60 FPS on a sustained basis, and you see 30 frames with VSync, then it is a problem with your video configuration. The shader does not control or block the FPS.

QueenUlyana commented 1 year ago

The shader does not block FPS. If your PC is not able to generate more than 60 FPS with shaders enabled, it is impossible for you to see more than 30 FPS with VSyc enabled, because VSync will always wait to paint on screen until an animation frame is finished, and if the machine does not finish a frame in 1/60th of a second, it will wait for the next one, that is 30 FPS.

But if your PC is capable of generating more than 60 FPS on a sustained basis, and you see 30 frames with VSync, then it is a problem with your video configuration. The shader does not control or block the FPS.

You're wrong, I've tried different presets. Some limited my FPS to 25 and some to 20. So it's not about my hardware, it's about the shader.

QueenUlyana commented 1 year ago

When you turn off V-Sync, the FPS immediately rises above 60. But I need to have V-Sync enabled.

javiergcim commented 1 year ago

Sorry. There is no code in the shader related to anything to do with FPS, VSync or similar. That is controlled entirely by Sodium/Iris, or Optifine, or your graphics card drivers.

My bet is that your PC is not powerful enough to sustain 60 fps with Vsync. You talk about having problems with the lowest shader profile. That means too little power.

With VSync disabled things always look smoother, but that doesn't mean you're hitting 60 FPS.

How many FPS does Minecraft give you with F3? What video card do you have? Do you use a laptop? Maybe the problem is overheating.

Do you have the same problem if you use Iris as if you use Optifine?