search

javiergcim / MakeUpUltraFast

High performance Minecraft shader (Java). For a graphical enhancement. Intended for low-spec computers.
GNU Lesser General Public License v3.0
97 stars 36 forks source link

Night Brightness Seems to Change and can get Too Dark to See #65

Closed KrabinDirt closed 9 months ago

KrabinDirt commented 10 months ago

Hi! I've searched everywhere I know to look for an answer to this question but can't find one.

Night brightness seems to change every night (which I suspect is due to moon phase or an autoexposure property), with some nights being bright (night brightness in my settings at max of 1 and cave brightness at 0.16) and other nights being very dark, so dark that I have trouble seeing what I'm doing, especially if it's also raining.

This is realistic and immersive, but I personally would like an option to turn this off, allowing every night to have the same brightness level. I don't have an issue with darkness in caves or other dimensions, only on the overworld surface some nights.

I can't find an option for this in settings, so I'm guessing this can probably be done by disabling something in a config file or disabling a function in the source code, but I can't seem to find anything. (playing latest MakeUp version v8.9a 1.20.2 fabric iris)

Thanks!

KrabinDirt commented 10 months ago

I figured it out! shaders/lib/color_utils.glsl I simply replaced #define NIGHT_BRIGHT_PHASE (NIGHT_BRIGHT + (NIGHT_BRIGHT * (abs(4 - moonPhase) * 0.25))) with #define NIGHT_BRIGHT_PHASE (NIGHT_BRIGHT * 2) This removes the influence of moon phase on night brightness, giving every night the brightness of a full moon.

It would be really cool if this could be an option to toggle on/off in settings.

KrabinDirt commented 9 months ago

Thanks for adding this option in settings in v.8.9b !!

MakeUp Ultrafast is my favorite shader by far. It looks absolutely stunning, and it can actually run really well on my mid-tier pc. Your work allows people without an expensive pc to experience some of the most beautiful visuals in modded MC. Thank you!