search

javiergcim / MakeUpUltraFast

High performance Minecraft shader (Java). For a graphical enhancement. Intended for low-spec computers.
GNU Lesser General Public License v3.0
97 stars 36 forks source link

Expanding black cloud bug with Powah! Energizing Rod #75

Closed yurikus closed 4 months ago

yurikus commented 4 months ago

MC: 1.20.1 Modpack: v1.7.4 https://www.curseforge.com/minecraft/modpacks/ozone-skyblock-reborn Powah! v5.0.5 https://www.curseforge.com/minecraft/mc-mods/powah-rearchitected

Shader mod: oculus-mc1.20.1-1.6.15a Shader pack: MakeUp-UltraFast-8.9d

NO optifine

Repro: https://www.youtube.com/watch?v=ms-Q8jbL2RA

javiergcim commented 4 months ago

Hello!

Do you use an AMD GPU?

yurikus commented 4 months ago

1080Ti, sorry for missing this I also realized that this does NOT happen in rainy/overcast weather EDIT: might have spoken too soon, it might be that even the slightest bloom from the sun triggers it

javiergcim commented 4 months ago

Thank you. It's a problem that I've had for some time now and which I've been unable to solve yet, since it doesn't happen on all devices.

There is a provisional solution and it consists in disabling temporal sampling completely. I know this makes the image look a bit "noisy", but it eliminates that black stain that invades the screen.

yurikus commented 4 months ago

This is what's happening with TAA off https://youtu.be/tY9OJy8PfjU LMK if you need to me to test anything else.

javiergcim commented 4 months ago

Mmm. It's clear that the problem doesn't originate from the reason I thought at first. I'll need to review it again, but I don't promise a solution in the short term. Resolving compatibility issues with mods usually takes up time that I don't have right now.

yurikus commented 4 months ago

No worries, lmk when you're ready to test/debug, I can assist. I learned if I look away during the process it's fine :)

javiergcim commented 4 months ago

The last version (8.9e) must solve the problem of dark spots. Confirm and close this thread.

yurikus commented 4 months ago

Fix confirmed, thank you!