search

javiergcim / MakeUpUltraFast

High performance Minecraft shader (Java). For a graphical enhancement. Intended for low-spec computers.
GNU Lesser General Public License v3.0
97 stars 36 forks source link

Strange artifact while looking at ice #84

Open xFrah opened 2 months ago

xFrah commented 2 months ago

2024-07-03_17 26 47 2024-07-03_17 29 27

The artifact appears only in the ice part of the screen.

javiergcim commented 2 months ago

Hi.

I don't see any unexpected behavior in the images. If you are referring to the "strange" reflections seen in the ice behind the door frame, such as the hanging lamp, this is a consequence of the implementation and is expected behavior.

Water or ice can only reflect objects that are previously drawn on the screen, and the calculation of what should be reflected has to deal with occlusions that require some computing power. These techniques are simplified in Makeup to favor speed at the cost of some imprecision in certain contexts or to avoid worse behavior in others.

xFrah commented 2 months ago

Well it's still a wrong reflection. But if the downside of fixing it is a much worse performance then it's all sorted.