search

javiergutierrezchamorro / nikkhokkho

Software Javier Gutiérrez Chamorro (Guti)
http://nikkhokkho.sourceforge.net/
7 stars 4 forks source link

FileOptimizer Info Box Non-Functional Under Any Theme ≠ Windows #10

Open TPS opened 8 years ago

TPS commented 8 years ago

@javiergutierrezchamorro I expect this is a known problem, but this FileOptimizer Metropolis theme info box is all that shows after pressing the Information menu entry/ribbon button on 9.00.1537ß. I'm on Win10 x64, & was hoping to try out the new Stats section (https://github.com/svn2github/nikkhokkho/commit/0e06e4b4e14b6291cccce86555177e153f369563 ).

javiergutierrezchamorro commented 8 years ago

Thank you for your report.

I discovered, it is a conflict between Embarcadero's themes and Microsoft TaskDialog implementation in Windows 10 Anniversary update.

Thought it only happened with Windows 10 theme, and so I switched back to Windows default theme which fixed the problem. I will do the same for Metropolis, there is no other possibility than reverting it back.

Nothing wrong in my code, and no idea what has been changed on the Anniversary update for the visuals in order to affect it.

TPS commented 8 years ago

Thanks! I'll wait for next ß-release & try it out then. ☺

TPS commented 8 years ago

I just installed & ran 9.00.1541 from today - still have identical issue. Also, I've always run the Metropolis theme (that's why the above image is black, after all), so I'm not sure the fix would work for it. When I change to the default Windows theme, all works well, though, but _all_ other themes are broken.

javiergutierrezchamorro commented 8 years ago

Under Windows 10, FileOptimizer should restore the selected theme to Windows, no matter if it was Metropolis or Windows 10. So unless you manually change it again after restart, should work.

Is it restoring the theme for you?

TPS commented 8 years ago

It did do so, but it's too pastel-y for me, so I switched it back, not knowing it was intentional. Then I remembered about the info box, tried it, & then reported back. Then I thought about trying all the themes. Does each 1 need to be fixed/reverted?

javiergutierrezchamorro commented 8 years ago

At the moment is only a temporary solution. I am evaluating either removing all themes, or trying to upgrade to C++ Builder 10.1, and see if that gets fixed.

Unfortunately 10.1 is not natively supporting ribbons, so if that is the case, I should discard it.

TPS commented 8 years ago

There's an excellent blog post from Embarcadero @ http://community.embarcadero.com/blogs/entry/ribbon-controls-in-rad-studio-10-1-berlin explaining the details of their ribbon problems, & are pointing toward https://github.com/TurboPack/RibbonFramework for a current fix, with an official package coming soon.

javiergutierrezchamorro commented 8 years ago

Thank you for the hint TPS. I already read that. Problem with RibbonFramework, is: 1) It is API icompatible with Embarcadero's one, so it will require a rewrite. 2) It is only compatible in Vista or later, so FO will not run on Windows XP anymore. Since it is statically linked, could not conditionally switch to menus on XP, and Ribbon in Vista+.

I am considering now different choices: 1) Purchasing a third party component such as DevExpress. Problem is they are expensive, and will restrict the opensourceness of FO, because will require it to compile. 2) Drop the ribbon interface, and keep the menus. To this, I added the dual ribbon/menus interface in 9.0. Just in case I should drop ribbons.

TPS commented 8 years ago

I was wondering why the menus made an appearance! But why not replace the ribbon with a toolbar (while leaving in option for menus)? That should have very good support over any version of Windows, & shouldn't have any licensing issues.