search

javiergutierrezchamorro / nikkhokkho

Software Javier Gutiérrez Chamorro (Guti)
http://nikkhokkho.sourceforge.net/
7 stars 4 forks source link

.ico (Icons) crash TruePNG #2

Closed TPS closed 8 years ago

TPS commented 8 years ago

Everytime I recompress .ico (icons), TruePNG crashes. The rest of the tool-chain seems fine, though getting any results (i.e. actual byte-saving) seems spotty.

javiergutierrezchamorro commented 8 years ago

I am aware on that. Unfortunately tried contacting TruePNG developer without any luck.

TPS commented 8 years ago

Wouldn't it better just to remove TruePNG from the .ico chain until TruePNG gets fixed?

javiergutierrezchamorro commented 8 years ago

Problem is that it is not crashing on all ico files, at least according to my tests, and if they internaly use PNG compression gets improved by using TruePNG.

Is it crashing for you on all ico files, or only on some?

TPS commented 8 years ago

I've never found a .ico on which TruePNG doesn't crash for me.

TPS commented 8 years ago

Just FYI: According to http://x128.ho.ua/pngutils.html, TruePNG's been updated to 0.6.2.2 on April 3. Maybe it helps this?

I just noticed you updated this already via https://github.com/svn2github/nikkhokkho/commit/d9f09d75ff1d68153bbbbf7794cc0df0d40fa245, so I'll wait for the appropriate release to test.

javiergutierrezchamorro commented 8 years ago

Exactly. Thanks. TruePNG has been disabled as of r447.

TPS commented 8 years ago

I'm assuming just with .ico's, right?

Thanks!

TPS commented 8 years ago

if they internaly use PNG compression gets improved by using TruePNG.

It occurs to me, a better (but more labor-intensive) method to work around this is to use ImageMagick or a dedicated tool to decompile .ico's to (a series of) .png's, run the .png chain on each (which should be reasonably quick, as I think even the HD icons top-out @ 32bit×256×256), & then recompile to feed the rest of the .ico chain.

javiergutierrezchamorro commented 8 years ago

Yes, only for ico file types (.ico and .spl extensions).