search

javierhonduco / lightswitch

CPU profiler for Linux written in Rust
MIT License
7 stars 3 forks source link

build: Disable debuginfod support in readelf #32

Closed javierhonduco closed 6 months ago

javierhonduco commented 6 months ago

It pulls a bunch of code we don't need, such as a web server.

Test Plan

CI

gmarler commented 6 months ago

The use of ' to denote that you're using an altered configuration of elfutils confused me for a bit - finally find a reference to the naming convention and what it denotes here.

But it would be good to have a comment before such lines denoting that you're creating elfutils "prime" - or if we end up doing this a lot (which we probably will), put a blurb in the project README and reference that in a comment.

This is the first time I've ever heard of this practice, but it's certainly a good one.

javierhonduco commented 6 months ago

Good point, will add this in a style guide / contributing doc in few weeks :)