Pluggable metadata library for generating sample labels - Githubissues

javierhonduco / lightswitch

CPU profiler for Linux written in Rust

MIT License

7 stars 3 forks source link

Pluggable metadata library for generating sample labels #83

Closed patnebe closed 4 weeks ago

patnebe commented 1 month ago

Context

Collection of various off-CPU metadata for profiles to provide additional context during analysis. These metadata are applied as labels to each pprof sample, and will be used to enable rich filtering of profiles on the backend UI.

Changes

Define a MetadataProvider trait and a GlobalMetadataProvider to encapsulate the logic for retrieving task metadata.
Move the existing labels into the provider, and hook up the provider in main.
Implement basic LRU caching to limit the number of processes for which labels are held in memory.

Future changes for a follow-up PR

Runtime detection
Mapping k8s units of work to tasks

Test Plan

Manual tests + Unit tests.

javierhonduco commented 1 month ago

This PR didn't break main, I did, sorry! Will fix it.